Ozone cdn invalidation #2087
Ozone cdn invalidation #2087
Conversation
| const paths = (this.cdnPaths ?? []).map((path) => | ||
| path.replace('%s', subject.did), | ||
| ) |
There was a problem hiding this comment.
I'm not noticing a place where the cid is also inserted into the path. Pretty sure the invalidators themselves don't do this, so I think we'd want it around here.
There was a problem hiding this comment.
hmm yup you're totally right i thought the img invalidator took care of that tbh 😅
| const { | ||
| BunnyInvalidator, | ||
| CloudfrontInvalidator, | ||
| MultiImageInvalidator, | ||
| } = require('@atproto/aws') |
There was a problem hiding this comment.
We may need to adjust the service's package.json and dockerfile to include @atproto/aws.
There was a problem hiding this comment.
Easiest thing to check/catch this is to make a build and run it, even if it's unconfigured.
There was a problem hiding this comment.
yup yup good point 👍
| await Promise.allSettled( | ||
| (subject.blobCids ?? []).map((cid) => { | ||
| const paths = (this.cdnPaths ?? []).map((path) => | ||
| path.replace('%s', subject.did).replace('%s', cid), |
There was a problem hiding this comment.
No issue here, but node's util.format() does this exact printf-style replacement! Would look something like util.format(path, subject.did, cid).
Move CDN invalidation to Ozone. Invalidation is pushed out after the takedown event is pushed to appview.