Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build system rework #2169

Merged
merged 81 commits into from
Mar 18, 2024
Merged

Build system rework #2169

merged 81 commits into from
Mar 18, 2024

Conversation

matthieusieben
Copy link
Contributor

@matthieusieben matthieusieben commented Feb 12, 2024

This is a simpler rework of the build system, replacing my previous attempt (#1941).

Here is what is included in this PR:

  • refactor(crypto): remove circular dependency #1942
  • Extract common tsconfig into shared tsconfig/common.json and tsconfig/test.json
  • Remove all direct access to src from other packages. Every import must be exported by the dependency's index.ts.
  • Remove unused babel.config.js files.
  • Most packages are no longer bundled. The esbuild + tsc build process has been replaced with a single tsc command. Published packages should be lighter by a factor >= 50%.
  • More files are covered by the lint
  • Improved linting & type-ckecking of all jest config & test files
  • Add "watch" mode build (pnpm dev)
  • A few minor adaptations to make things run smoothly
  • Narrow types available in packages depending on the target (e.g. remove dom lib from NodeJS only packages)
  • Add typings for handlebar templates

@matthieusieben matthieusieben marked this pull request as draft February 13, 2024 14:28
@matthieusieben matthieusieben marked this pull request as ready for review February 19, 2024 20:00
matthieusieben and others added 28 commits February 23, 2024 10:30
npm-run-all seems not to be maintained anymore. Additionally, concurrently better forwards signals to child processes.
@devinivy devinivy merged commit f689bd5 into bluesky-social:main Mar 18, 2024
10 checks passed
@github-actions github-actions bot mentioned this pull request Mar 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants