Ozone delegates email sending to actor's pds #2272
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dholms
approved these changes
Mar 5, 2024
dholms
pushed a commit
that referenced
this pull request
Mar 5, 2024
* ozone delegates email sending to user's pds * lexicon: add content field to mod email event * test email sending via mod event
dholms
added a commit
that referenced
this pull request
Mar 6, 2024
* tidy bsky auth * hook up new auth verifier * update auth throughout ozone * handle mod signing keys * fix bad var * fix key parsing in pds * fix admin auth test * rename test * update did doc id values * null creds string -> `none` * fix fetchLabels auth check * ✨ Add a couple more proxied requests that we use in ozone ui * Add runit to the services/bsky Dockerfile (#2254) add runit to the services/bsky Dockerfile * Improve tag detection (#2260) * Allow tags to lead with and contain only numbers * Break tags on other whitespace characters * Export regexes from rich text detection * Add test * Add test * Disallow number-only tags * Avoid combining enclosing screen chars * Allow full-width number sign * Clarify tests * Fix punctuation edge case * Reorder * Simplify, add another test * Another test, comment * Version packages (#2261) Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * 🐛 Increment attempt count after each attempt to push ozone event (#2239) * Ozone delegates email sending to actor's pds (#2272) * ozone delegates email sending to user's pds * lexicon: add content field to mod email event * test email sending via mod event * fix auth verifier method * better error handling for get account infos * fix labeler service id * fix iss on auth headers * fix dev-env ozone did * fix tests & another jwt issuer * ozone: fix ip check * fix aud check on pds mod service auth * tidy --------- Co-authored-by: Foysal Ahamed <foysal@blueskyweb.xyz> Co-authored-by: Jake Gold <52801504+Jacob2161@users.noreply.github.com> Co-authored-by: Eric Bailey <git@esb.lol> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: devin ivy <devinivy@gmail.com>
dholms
added a commit
that referenced
this pull request
Mar 7, 2024
* tidy bsky auth * hook up new auth verifier * update auth throughout ozone * handle mod signing keys * add client proxy heads to pds * hook up rest of routes * simplify pipethrough & add some SSRF protection * tests * fix bad var * fix key parsing in pds * fix admin auth test * rename test * add pipethrough to write routes * update did doc id values * null creds string -> `none` * fix fetchLabels auth check * ✨ Add a couple more proxied requests that we use in ozone ui * Add runit to the services/bsky Dockerfile (#2254) add runit to the services/bsky Dockerfile * Improve tag detection (#2260) * Allow tags to lead with and contain only numbers * Break tags on other whitespace characters * Export regexes from rich text detection * Add test * Add test * Disallow number-only tags * Avoid combining enclosing screen chars * Allow full-width number sign * Clarify tests * Fix punctuation edge case * Reorder * Simplify, add another test * Another test, comment * Version packages (#2261) Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * 🐛 Increment attempt count after each attempt to push ozone event (#2239) * Ozone delegates email sending to actor's pds (#2272) * ozone delegates email sending to user's pds * lexicon: add content field to mod email event * test email sending via mod event * fix auth verifier method * build branch * fix url check * better error handling for get account infos * fix labeler service id * fix iss on auth headers * fix dev-env ozone did * fix tests & another jwt issuer * ozone: fix ip check * fix aud check on pds mod service auth * tidy * fix pipethrough of headers --------- Co-authored-by: Foysal Ahamed <foysal@blueskyweb.xyz> Co-authored-by: Jake Gold <52801504+Jacob2161@users.noreply.github.com> Co-authored-by: Eric Bailey <git@esb.lol> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: devin ivy <devinivy@gmail.com>
dholms
added a commit
that referenced
this pull request
Mar 7, 2024
* tidy bsky auth * hook up new auth verifier * update auth throughout ozone * handle mod signing keys * add client proxy heads to pds * hook up rest of routes * simplify pipethrough & add some SSRF protection * tests * fix bad var * remove basic auth in ozone * wip * fix key parsing in pds * fix up all ozone tests * fix admin auth test * rename test * fix ozone test * clean up tokens in pds * fix up pds tests * fix up ozone tests * add pipethrough to write routes * reenable proxied admin test * add moderator accounts to ozone in dev-env * update did doc id values * null creds string -> `none` * fix fetchLabels auth check * ✨ Add a couple more proxied requests that we use in ozone ui * Add runit to the services/bsky Dockerfile (#2254) add runit to the services/bsky Dockerfile * Improve tag detection (#2260) * Allow tags to lead with and contain only numbers * Break tags on other whitespace characters * Export regexes from rich text detection * Add test * Add test * Disallow number-only tags * Avoid combining enclosing screen chars * Allow full-width number sign * Clarify tests * Fix punctuation edge case * Reorder * Simplify, add another test * Another test, comment * Version packages (#2261) Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * 🐛 Increment attempt count after each attempt to push ozone event (#2239) * Ozone delegates email sending to actor's pds (#2272) * ozone delegates email sending to user's pds * lexicon: add content field to mod email event * test email sending via mod event * add dev dep for nodemailer in ozone * fix auth verifier method * build branch * build branch * fix url check * better error handling for get account infos * fix labeler service id * fix iss on auth headers * fix dev-env ozone did * fix tests & another jwt issuer * fix proxy auth * ozone: fix ip check * fix aud check on pds mod service auth * tidy * Update packages/pds/tests/proxied/admin.test.ts Co-authored-by: devin ivy <devinivy@gmail.com> * fix pipethrough of headers * fix moderation status tests * fix auth on ozone routes * update iss on daemon --------- Co-authored-by: Foysal Ahamed <foysal@blueskyweb.xyz> Co-authored-by: Jake Gold <52801504+Jacob2161@users.noreply.github.com> Co-authored-by: Eric Bailey <git@esb.lol> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: devin ivy <devinivy@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When an email event is sent to
emitModerationEventon ozone and the input includesmeta.content, ozone attempts to prompt the user's pds to send an email. Sincemeta.contentis not typically included, this change is backwards compatible. Pals with #2271.