-
Notifications
You must be signed in to change notification settings - Fork 635
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OAuth: Reset password & Sign-up #2945
Conversation
c0c3a55
to
64357d1
Compare
64357d1
to
bcc7f5d
Compare
01c11c6
to
0dbb458
Compare
bb81208
to
3f768b2
Compare
e22b78d
to
9a40a57
Compare
9a40a57
to
d1e3858
Compare
atproto/packages/oauth/oauth-provider/src/lib/locale.ts Lines 3 to 6 in 1e78fa0
Apologies if I've misunderstood what's going on here, I just wanted to check: would this regex work OK with three-letter locales? We currently have one: |
@surfdude29 you're right. This would not have been an issue until we actually provided Asturian translations but I fixed it nonetheless. |
9e2e46c
to
d68f3c5
Compare
d68f3c5
to
0e366ed
Compare
Ah got it 👍 Thanks for fixing it (and thanks also for making the strings easier to translate) 🙏 Also, sorry for commenting again, I just noticed one other tiny thing: would it be possible to mark this atproto/packages/oauth/oauth-provider/src/assets/app/components/utils/password-strength-label.tsx Line 22 in 0043548
|
No description provided.