Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OAuth: Reset password & Sign-up #2945

Merged
merged 92 commits into from
Mar 7, 2025
Merged

OAuth: Reset password & Sign-up #2945

merged 92 commits into from
Mar 7, 2025

Conversation

matthieusieben
Copy link
Contributor

No description provided.

@matthieusieben matthieusieben marked this pull request as draft December 3, 2024 08:34
@matthieusieben matthieusieben changed the base branch from main to msi/refactor-actor-store-reader February 4, 2025 14:43
@matthieusieben matthieusieben force-pushed the msi/refactor-actor-store-reader branch from 01c11c6 to 0dbb458 Compare February 5, 2025 07:47
Base automatically changed from msi/refactor-actor-store-reader to main February 5, 2025 12:37
@matthieusieben matthieusieben force-pushed the msi/oauth-reset-pwd branch 5 times, most recently from bb81208 to 3f768b2 Compare February 10, 2025 17:29
@matthieusieben matthieusieben force-pushed the msi/oauth-reset-pwd branch 17 times, most recently from e22b78d to 9a40a57 Compare February 26, 2025 21:35
@surfdude29
Copy link
Contributor

export const localeSchema = z
.string()
.regex(/^[a-z]{2}(-[A-Z]{2})?$/, 'Invalid locale')
export type Locale = z.infer<typeof localeSchema>

Apologies if I've misunderstood what's going on here, I just wanted to check: would this regex work OK with three-letter locales? We currently have one: ast (Asturian).

@matthieusieben
Copy link
Contributor Author

@surfdude29 you're right. This would not have been an issue until we actually provided Asturian translations but I fixed it nonetheless.

@surfdude29
Copy link
Contributor

surfdude29 commented Mar 6, 2025

@surfdude29 you're right. This would not have been an issue until we actually provided Asturian translations but I fixed it nonetheless.

Ah got it 👍

Thanks for fixing it (and thanks also for making the strings easier to translate) 🙏

Also, sorry for commenting again, I just noticed one other tiny thing: would it be possible to mark this aria-label for translation please?

@matthieusieben matthieusieben merged commit 850e398 into main Mar 7, 2025
1 check passed
@matthieusieben matthieusieben deleted the msi/oauth-reset-pwd branch March 7, 2025 08:41
@github-actions github-actions bot mentioned this pull request Mar 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants