-
Notifications
You must be signed in to change notification settings - Fork 635
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
lex-cli: Fix TS Errors with codegen #3282
Conversation
@matthieusieben sorry to poke, but I wanted to ask if there's anything blocking this from getting merged. I wanted to remove the patchfile from my repo as soon as possible. |
We are working on a major upgrade of the api package. I'm waiting for it to be merged before I come back to this one. I'm keeping this on my radar, I promise ! |
Gotcha. I'll remove the changes that are covered by your PR to make the merge conflicts a bit easier to deal with. |
f074bb5
to
b4674a6
Compare
I squashed everything to remove the merge commit. There's a Windows issue that prevents me from building + testing the repo (details). I'll submit an Issue / PR for this one too. I don't think I can resolve the "This branch must not contain merge commits." error from GitHub on my end. This is probably because there are merge commits that predate my PR in the branch that I can't remove. |
c8a40a3
to
09bf71c
Compare
Rebuilt the lockfile so PR can run |
09bf71c
to
fe92c87
Compare
Fixed Lint Issue since that's the only thing failing for the PR |
1d0c3e1
to
40e9012
Compare
I've fixed the latest merge conflict and the linter issue. @matthieusieben would you be able to rerun the workflow. |
Thank you for your patience with this ! Could you please provide a changeset (by running |
Sorry for the delay. Let me know if this is how the changeset is supposed to look like. |
Sorry for poking you again @matthieusieben. I updated everything to remove merge conflicts. I believe I made the changesets correctly (minor change for lex-cli, patch change for all other codegen packages). |
Co-authored-by: Timothy Cyrus <4201229+tcyrus@users.noreply.github.com>
94731a4
to
014f525
Compare
hey @tcyrus thank you for your contribution and patience 🥸 |
These are fixes for the TypeScript Errors (#3230) that I encountered with the lex-cli codegen output.
The specific changes are:
ts-morph
to^24.0.0
isTypeOnly
to named imports in codegen where relevantThe new codegen output should be functionally the same (if it was working before, it should still work). I tried to avoid making any breaking changes.
I'm already using this patched version of lex-cli for a personal project.