✨ Add team member handle and displayName #3587

foysalit · 2025-02-25T20:41:54Z

This PR adds handle and displayName columns to the member table and keeps those values in sync with member profile through a new daemon that runs every 24hrs by default.

This allows searching for team members using handle/display name.

foysalit · 2025-02-26T00:14:56Z

packages/ozone/src/daemon/context.ts

+    const teamProfileSynchronizer = new TeamProfileSynchronizer(
+      backgroundQueue,
+      {
+        createAuthHeaders: (method: string) =>


This reads a bit weird but basically can't come up with a better, more context aware name that would work elsewhere as well as here.

It might make sense to pass the appviewAgent and appviewDid as argument to the new TeamService() constructor, then used as:

const options = createAuthHeaders(this.appviewDid, 'foo.bar') this.agent.foo.bar(params, options)

See my other comment for a more detailed example

I like that pretty well too 👍

foysalit · 2025-02-26T00:19:44Z

packages/ozone/src/team/index.ts


 export type TeamServiceCreator = (db: Database) => TeamService
+export type AppviewCreator = {


Refactoring away from passing the whole AppContext since we want to be able to run this from both app and daemon.

Since you take the opportunity to refactor, you should change this from being a method argument to a constructor argument:

class TeamService { constructor( protected readonly db: Database, protected readonly appviewAgent: AtpAgent, protected readonly appviewDid: string, ) {} async getProfiles(dids: string[]) { const {headers} = createAuthHeaders(this.appviewDid, method) const result = await this.appviewAgent(...) } }

(this is the same comment as above)

matthieusieben · 2025-03-04T14:38:29Z

packages/ozone/src/daemon/team-profile-synchronizer.ts

+    interval = 24 * HOUR,
+  ) {
+    super(backgroundQueue, interval, async (_, signal) => {
+      if (signal.aborted) return


There is no need to check if the signal is aborted here. This check is only needed between tasks (if multiple statements, or during loops)

Suggested change

if (signal.aborted) return

matthieusieben

I think that a minor refactor here could make things a little more neat.

We should probably name the handle and displayName with a cached prefix to clearly indicate that these are not a real source of thruth.

matthieusieben · 2025-03-04T14:47:42Z

packages/ozone/tests/team.test.ts

@@ -11,6 +11,9 @@ describe('team management', () => {
  beforeAll(async () => {
    network = await TestNetwork.create({
      dbPostgresSchema: 'ozone_team_test',
+      ozone: {
+        dbTeamProfileRefreshIntervalMs: 1000,


There probably need to be a "wait for 1 second since the member was added to the list" in the tests below here somewhere to prevent tests from being flaky on fast machines.

You could event change this interval to something smaller.

Since the information is fetched when the member is added, I don't think the refresh interval is ever really used (or perhaps I missed something). Could we disable it altogether? (Also—isn't it only used by the daemon and not ozone proper?)

i believe the daemon processes are run when processAll() is called in test network and for this test, we are creating the members with handle and displayName null to kinda implicitly test that the background sync works.

matthieusieben · 2025-03-04T14:54:28Z

packages/ozone/src/daemon/context.ts

+    const teamProfileSynchronizer = new TeamProfileSynchronizer(
+      backgroundQueue,
+      {
+        createAuthHeaders: (method: string) =>


It might make sense to pass the appviewAgent and appviewDid as argument to the new TeamService() constructor, then used as:

const options = createAuthHeaders(this.appviewDid, 'foo.bar') this.agent.foo.bar(params, options)

See my other comment for a more detailed example

devinivy · 2025-03-03T06:41:32Z

packages/ozone/src/db/migrations/20250221T132135150Z-member-details.ts

+  await db.schema
+    .createIndex('member_display_name_idx')
+    .on('member')
+    .column('displayName')
+    .execute()
+  await db.schema
+    .createIndex('member_handle_idx')
+    .on('member')
+    .column('handle')
+    .execute()


I don't think that these indexes can be used for the ilike queries, if that is their purpose.

oh right. I'm gonna go with trgm, i think i saw an example of that somewhere else.

devinivy · 2025-03-04T15:49:27Z

packages/ozone/src/daemon/context.ts

+    const teamProfileSynchronizer = new TeamProfileSynchronizer(
+      backgroundQueue,
+      {
+        createAuthHeaders: (method: string) =>


I like that pretty well too 👍

devinivy · 2025-03-04T15:53:44Z

packages/ozone/src/team/index.ts

+    const { count } = await this.db.db
+      .selectFrom('member')
+      .select(this.db.db.fn.count<number>('did').as('count'))
+      .executeTakeFirstOrThrow()
+
+    let lastDid = ''
+    // Max 25 profiles can be fetched at a time so let's pull 25 members at a time from the db and update their profile details
+    for (let i = 0; i < count; i += 25) {


Rather than fetching the count and relying on it not changing, you could alternately only use the lastDid to iterate through. I think it's sort of nice since you're already iterating by lastDid. It would look more like:

let lastDid = '' do { // ... lastDid = dids.at(-1) || '' } while (lastDid)

devinivy · 2025-03-04T15:56:48Z

packages/ozone/src/api/team/addMember.ts

+          agent: ctx.appviewAgent,
+          createAuthHeaders: ctx.appviewAuth,
+        }
+        const profiles = await teamService.getProfiles([did], appviewCreator)


It would be kind of nice if adding a member would still complete even if fresh profile information couldn't be fetched.

yeah teamService.getProfiles handles failures internally and won't throw error if fetching profile fails.

…eam-member-details

foysalit added 2 commits February 22, 2025 15:32

✨ Add team member handle and displayName

244f487

✨ Add periodic profile details sync

82a821e

foysalit commented Feb 26, 2025

View reviewed changes

foysalit marked this pull request as ready for review February 26, 2025 00:17

foysalit requested a review from matthieusieben February 26, 2025 00:17

foysalit commented Feb 26, 2025

View reviewed changes

📝 Add changeset

bf4280e

foysalit mentioned this pull request Mar 3, 2025

❇️ Team member search bluesky-social/ozone#308

Merged

matthieusieben reviewed Mar 4, 2025

View reviewed changes

devinivy reviewed Mar 4, 2025

View reviewed changes

foysalit added 2 commits March 5, 2025 20:20

✨ Update team service instantiation

6df698a

🐛 Cleanup

8c509f0

foysalit requested review from matthieusieben and devinivy March 5, 2025 21:50

foysalit added 2 commits March 7, 2025 22:48

🧹 Cleanup unnecessary index

e8dfd2f

Merge branch 'main' of github.com:bluesky-social/atproto into ozone-t…

d0d74d7

…eam-member-details

devinivy approved these changes Mar 7, 2025

View reviewed changes

foysalit merged commit 18fbfa0 into main Mar 7, 2025
10 checks passed

foysalit deleted the ozone-team-member-details branch March 7, 2025 23:00

github-actions bot mentioned this pull request Mar 7, 2025

Version packages #3613

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

✨ Add team member handle and displayName #3587

✨ Add team member handle and displayName #3587

foysalit commented Feb 25, 2025 •

edited

Loading

foysalit Feb 26, 2025

matthieusieben Mar 4, 2025 •

edited

Loading

devinivy Mar 4, 2025

foysalit Feb 26, 2025

matthieusieben Mar 4, 2025 •

edited

Loading

matthieusieben Mar 5, 2025

matthieusieben Mar 4, 2025

matthieusieben left a comment

matthieusieben Mar 4, 2025

devinivy Mar 4, 2025

foysalit Mar 5, 2025

matthieusieben Mar 4, 2025 •

edited

Loading

devinivy Mar 3, 2025

foysalit Mar 5, 2025

devinivy Mar 4, 2025

devinivy Mar 4, 2025 •

edited

Loading

devinivy Mar 4, 2025

foysalit Mar 5, 2025


		export type TeamServiceCreator = (db: Database) => TeamService
		export type AppviewCreator = {

✨ Add team member handle and displayName #3587

✨ Add team member handle and displayName #3587

Conversation

foysalit commented Feb 25, 2025 • edited Loading

Choose a reason for hiding this comment

matthieusieben Mar 4, 2025 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

matthieusieben Mar 4, 2025 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

matthieusieben left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

matthieusieben Mar 4, 2025 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

devinivy Mar 4, 2025 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

foysalit commented Feb 25, 2025 •

edited

Loading

matthieusieben Mar 4, 2025 •

edited

Loading

matthieusieben Mar 4, 2025 •

edited

Loading

matthieusieben Mar 4, 2025 •

edited

Loading

devinivy Mar 4, 2025 •

edited

Loading