Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

did: Allow Ed25519 #3620

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

lorenzleutgeb
Copy link

@lorenzleutgeb lorenzleutgeb commented Mar 9, 2025

This is a follow-up on #181, see #181 (comment)

Add parsing, decoding, encoding, signing, verification for Ed25519 via @noble/curves/ed25519. Analogous to the already existing curves. packages/crypto/src/ed25519/operation.ts is a straightforward modification of a copy of packages/crypto/src/secp256k1/operation.ts. Note that there's no compression, i.e. {de,}compressPubkey are trivial.

Should be released only after did-method-plc/did-method-plc#93

@lorenzleutgeb
Copy link
Author

@foysalit, kindly asking you to approve workflows for me. Thanks!

@lorenzleutgeb lorenzleutgeb force-pushed the did-key-ed25519 branch 2 times, most recently from 3bb5fb7 to 6e51a86 Compare March 9, 2025 17:02
@bnewbold
Copy link
Collaborator

bnewbold commented Mar 9, 2025

This is something we are open to considering over time, but it should start as a protocol conversation before implementation work.

Ed25519 is a popular system, and we considered it when selecting the original 2x cryptographic systems. If we are going to add the complexity of a third system, which every implementation of atproto would be expected to adopt, we would want to make sure there are clear and unique/novel advantages to that additional system, however.

@lorenzleutgeb
Copy link
Author

lorenzleutgeb commented Mar 10, 2025

What is a protocol conversation?

Please also note my other, linked PR which restricts rotation keys and verification methods for "atproto" to P-256 or secp256k1, even if @atproto/crypto would support more did:key algorithms.

The reason for allowing Ed25519 is because I would like to link my did:plc with a verification method that simply does not support either P-256 nor secp256k1, but does support Ed25519.

Just adding an Ed25519 verification method with ID "radicle" would enable interoperability with Radicle. That is, it would allow did:plc to be used not only in an ATProtocol context but also in a Radicle context.

From what I understand, such openness is a goal of did:plc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants