MNT: pass callbacks directly to _RE.__call__ #308
+1
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The second positional argument to RE() is subscriptions to processed for that invocation. This avoids adding one more layer to the callstack and a possible confusion with plans that do not set their own name being reported as having the `'plan_name'` of `'subs_wrapper'` in the start document.
|
Is it this warning which causes the documentation to fail?
|
mrakitin
approved these changes
Oct 14, 2024
|
We should test it in the lab before merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The second positional argument to RE() is subscriptions to processed for that invocation. This avoids adding one more layer to the callstack and a possible confusion with plans that do not set their own name being reported as having the
'plan_name'of'subs_wrapper'in the start document.Motivation and Context
This caused some confusion at HEX. The ultimate fix is that plans that generate start documents should insert their own name into the meta-data of the
open_runplan so that when used from inside of a bigger plan the name is stable. This change will not fix the ultimate problem, but it will change what the user sees to be the name of the plan they wrote so it will be clearer what is going on and what they have to do to fix it.Summary of Changes for Release Notes
How Has This Been Tested?
Expect all tests to pass after this change and there to be no meaningful user-facing change.