Skip to content

Commit

Permalink
some more improvement
Browse files Browse the repository at this point in the history
  • Loading branch information
Seher Karakuzu authored and Seher Karakuzu committed Apr 9, 2024
1 parent 4967f35 commit bfa73ed
Show file tree
Hide file tree
Showing 6 changed files with 17 additions and 13 deletions.
4 changes: 2 additions & 2 deletions tiled/adapters/awkward.py
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@ def metadata(self) -> JSON:
"""
return self._metadata

def read_buffers(self, form_keys: Optional[list[str]] = None) -> dict[Any, JSON]:
def read_buffers(self, form_keys: Optional[list[str]] = None) -> dict[str, Any]:
"""
Parameters
Expand All @@ -101,7 +101,7 @@ def read_buffers(self, form_keys: Optional[list[str]] = None) -> dict[Any, JSON]
buffers[key] = self.container[key]
return buffers

def read(self) -> JSON:
def read(self) -> dict[str, Any]:
"""
Returns
Expand Down
7 changes: 4 additions & 3 deletions tiled/adapters/awkward_buffers.py
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
A directory containing awkward buffers, one file per form key.
"""
import collections.abc
from collections.abc import Buffer
from pathlib import Path
from typing import Any, Iterator, List, Optional, Union

Expand All @@ -15,7 +16,7 @@
from .type_alliases import JSON


class DirectoryContainer(collections.abc.MutableMapping[str, JSON]):
class DirectoryContainer(collections.abc.MutableMapping[str, Buffer]):
""" """

def __init__(self, directory: Path, form: Any):
Expand All @@ -29,7 +30,7 @@ def __init__(self, directory: Path, form: Any):
self.directory = directory
self.form = form

def __getitem__(self, form_key: str) -> JSON:
def __getitem__(self, form_key: str) -> Buffer:
"""
Parameters
Expand All @@ -43,7 +44,7 @@ def __getitem__(self, form_key: str) -> JSON:
with open(self.directory / form_key, "rb") as file:
return file.read()

def __setitem__(self, form_key: str, value: JSON) -> None:
def __setitem__(self, form_key: str, value: Buffer) -> None:
"""
Parameters
Expand Down
2 changes: 1 addition & 1 deletion tiled/adapters/hdf5.py
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,7 @@ def from_file(
file: Any,
*,
structure: Optional[TableStructure] = None,
metadata: JSON = None,
metadata: Optional[JSON] = None,
swmr: bool = SWMR_DEFAULT,
libver: str = "latest",
specs: Optional[list[Spec]] = None,
Expand Down
5 changes: 4 additions & 1 deletion tiled/adapters/type_alliases.py
Original file line number Diff line number Diff line change
@@ -1,4 +1,7 @@
# JSON = dict[str, "JSON"] | list["JSON"] | str | int | float | bool | None
# from typing import Any
from typing import Any, Dict, List, Union

JSON = dict[str, "JSON"] | list["JSON"]
# JSON = dict[str, "JSON"] | list["JSON"]
JSONValue = Union[str, int, float, bool, None, Dict[str, Any], List[Any]]
JSON = Union[Dict[str, JSONValue], List[JSONValue]]
8 changes: 4 additions & 4 deletions tiled/adapters/zarr.py
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@

def read_zarr(
data_uri: Union[str, list[str]], structure: Optional[NodeStructure], **kwargs: Any
) -> Union["ZarrGroupAdapter", "ZarrArrayAdapter"]:
) -> Union["ZarrGroupAdapter", ArrayAdapter]:
"""
Parameters
Expand All @@ -41,7 +41,7 @@ def read_zarr(
"""
filepath = path_from_uri(data_uri)
zarr_obj = zarr.open(filepath) # Group or Array
adapter: Union[ZarrGroupAdapter, ZarrArrayAdapter]
adapter: Union[ZarrGroupAdapter, ArrayAdapter]
if isinstance(zarr_obj, zarr.hierarchy.Group):
adapter = ZarrGroupAdapter(zarr_obj, **kwargs)
else:
Expand Down Expand Up @@ -182,7 +182,7 @@ async def write_block(


class ZarrGroupAdapter(
collections.abc.Mapping[str, Union["ZarrArrayAdapter", "ZarrGroupAdapter"]],
collections.abc.Mapping[str, Union["ArrayAdapter", "ZarrGroupAdapter"]],
IndexersMixin,
):
""" """
Expand Down Expand Up @@ -264,7 +264,7 @@ def __iter__(self) -> Iterator[Any]:
"""
yield from self._node

def __getitem__(self, key: str) -> Union[ZarrArrayAdapter, "ZarrGroupAdapter"]:
def __getitem__(self, key: str) -> Union[ArrayAdapter, "ZarrGroupAdapter"]:
"""
Parameters
Expand Down
4 changes: 2 additions & 2 deletions tiled/structures/array.py
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
import os
import sys
from dataclasses import dataclass
from typing import List, Optional, Self, Tuple, Union
from typing import List, Optional, Tuple, Union

import numpy

Expand Down Expand Up @@ -236,7 +236,7 @@ def from_json(cls, structure):
)

@classmethod
def from_array(cls, array, shape=None, chunks=None, dims=None) -> Self:
def from_array(cls, array, shape=None, chunks=None, dims=None) -> "ArrayStructure":
from dask.array.core import normalize_chunks

if not hasattr(array, "__array__"):
Expand Down

0 comments on commit bfa73ed

Please sign in to comment.