Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix project_form for projections within a RecordArray field and for node types without indexes. #582

Merged
merged 4 commits into from
Oct 18, 2023
Merged

Fix project_form for projections within a RecordArray field and for node types without indexes. #582

merged 4 commits into from
Oct 18, 2023

Conversation

jpivarski
Copy link
Contributor

@jpivarski jpivarski commented Oct 17, 2023 •
edited
Loading

Issue #578 was because of a typo in the code that I sent you. The second and third fixes are more fundamental/conceptual.

Fixes #578.

danielballan
danielballan approved these changes Oct 18, 2023
View reviewed changes
Copy link
Member

@danielballan danielballan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks sensible. I played with these test cases interactively and did not hit any problems.

@danielballan
Copy link
Member

Thanks @jpivarski! Rolling a release momentarily to get this up on PyPI.

@danielballan danielballan merged commit 936b3a3 into bluesky:main Oct 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielballan danielballan danielballan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Can't slice (with predicate push-down) a field within a field of an Awkward Array
2 participants
@jpivarski @danielballan