Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup extraneous print() statements in tests #591

Merged
merged 8 commits into from
Oct 26, 2023
Merged

Cleanup extraneous print() statements in tests #591

merged 8 commits into from
Oct 26, 2023

Conversation

padraic-shafer
Copy link
Contributor

@padraic-shafer padraic-shafer commented Oct 25, 2023 •
edited
Loading

Closes #589

  • Converted several debug-style print() statements into assertions
  • Enable live logging for pytest
  • Use logger with custom log level (>INFO && <WARNING) for TILED_DEBUG_LEAKED_THREADS counting
    • Too many INFO log entries from normal use of client and server
    • Default reporting level is WARNING to keep test messages clean/terse

@padraic-shafer
Copy link
Contributor Author

@AbbyGi I fixed one last linter issue; could you please give this a look?

@AbbyGi AbbyGi merged commit 81804e1 into bluesky:main Oct 26, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmaruland jmaruland jmaruland approved these changes

@AbbyGi AbbyGi AbbyGi approved these changes

@danielballan danielballan danielballan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Clean up extraneous print() statements
4 participants
@padraic-shafer @danielballan @AbbyGi @jmaruland