Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

More fixes to the DataSource registration how-to giude #691

Merged
merged 4 commits into from
Mar 13, 2024
Merged

More fixes to the DataSource registration how-to giude #691

merged 4 commits into from
Mar 13, 2024

Conversation

danielballan
Copy link
Member

Somehow in the flurry of recent activity here I still had not tested that this example runs. Now it runs.

padraic-shafer
padraic-shafer approved these changes Mar 12, 2024
View reviewed changes
Copy link
Contributor

@padraic-shafer padraic-shafer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure when I'll have a chance to test this. But even if this turns out to be an incomplete fix, I favor adopting this improvement.

@genematx genematx merged commit e5a7726 into bluesky:main Mar 13, 2024
8 checks passed
@danielballan danielballan deleted the register-docs-more-fixes branch March 13, 2024 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@padraic-shafer padraic-shafer padraic-shafer approved these changes

@genematx genematx genematx approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@danielballan @genematx @padraic-shafer