Refactoring to allow adding multiple Assets (dynamic tiff sequences) #718
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
genematx
changed the title
genematx
changed the title
genematx
commented
Apr 15, 2024
| data_sources=None, | ||
| ): | ||
| @property | ||
| def insert(self): |
There was a problem hiding this comment.
I have factored out this bit into its own method because it's reused a couple of times throughout the class. Maybe call _insert?
genematx
commented
Apr 17, 2024
tiled/adapters/tiff.py
Outdated
| arr = tifffile.TiffSequence( | ||
| self._seq.files[slice_start : slice.stop : slice_step] # noqa: E203 | ||
| ).asarray() | ||
| # NOTE: may need to force np.array type if arr is a scalar |
There was a problem hiding this comment.
force to be arrays
genematx
commented
Apr 17, 2024
tiled/adapters/tiff.py
Outdated
| """ | ||
|
|
||
| if slice is None: | ||
| if (slice is None) or (slice is Ellipsis): |
danielballan
approved these changes
Apr 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
(1) implements minor cosmetic refactoring in
adapter.py; specifically, it separates the asset creation functionality into the_put_assetmethod, which is called when a new data source/ node is created and when an existing data source is updated. This allows to add new assets to an exisiting data source. (Possibly more refactoring needed to improve the speed).(2) expands the
TiffSequenceAdapterclass to accept tiff files with more than 2 dimensions (e.g. color images) and also to allow implicit slicing extension to arbitrary number of adjacent dimensions with Ellipsis.