Almost working pass header auth #844
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DiamondJoseph
commented
Jan 13, 2025
| @@ -0,0 +1,15 @@ | |||
| authentication: | |||
There was a problem hiding this comment.
This configuration works with the docker-compose contained in the oidc/ subdirectory. It will eventually be pared down to something that works as an example for the documentation, but for now is purely functional.
It seems Tiled's idea of a "principal" is at odds with Authentication handling as-is: the principal Depends in the FastAPI app is using a completely arbitrary Oauth2 configuration- I do not like how it tries to mutate the Oauth2PasswordBearer, and it is also entirely seperate from all other AuthN handling.
The FastAPI routing and Dependencies are a bit of a mess.
DiamondJoseph
force-pushed
the
almost-working-pass-header-auth
branch
from
9aadf96 to
920ceab
Compare
DiamondJoseph
force-pushed
the
almost-working-pass-header-auth
branch
from
920ceab to
7a919fa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minimal changes to Tiled to work when expected authentication headers to come as part of existing TiledClient with external AuthN. I will type up something more coherent tomorrow. Paired change in blueapi
Checklist