Blocked aria-hidden on an element because its descendant retained focus. #422

[3looy-hubs]

Describe your changes

After debugging, I found that the aria-hidden attribute was being added to the root element

when a Dialog opened, causing accessibility issues by hiding the focused element from assistive technologies. The issue was resolved by adding closeAfterTransition={open} to the Dialog, ensuring it remains mounted in the DOM during transitions and prevents the root element from being hidden. I also noticed the same issue occurred with the ConfirmationPopup, so I applied the same fix there to ensure consistent behavior across both components.

Briefly describe the changes you made and their purpose.

Issue number

this PR addresses Blocked aria-hidden on an element because its descendant retained focus. #422

Mention the issue number(s) this PR addresses (e.g., #123).

Please ensure all items are checked off before requesting a review:

• I deployed the code locally.
• I have performed a self-review of my code.
• I have included the issue # in the PR.
• I have labelled the PR correctly.
• The issue I am working on is assigned to me.
• I didn't use any hardcoded values (otherwise it will not scale, and will make it difficult to maintain consistency across the application).
• I made sure font sizes, color choices etc are all referenced from the theme.
• My PR is granular and targeted to one specific feature.
• I took a screenshot or a video and attached to this PR if there is a UI change.

[coderabbitai]

Walkthrough

The pull request introduces minor formatting and configuration changes to two React components: ConfirmationPopup.jsx and GuideTemplate.jsx. The modifications primarily involve standardizing quote usage from single to double quotes and adding a closeAfterTransition prop to Dialog components. These changes appear to be focused on code consistency and potentially refining dialog transition behaviors without significantly altering the core functionality of the components.

Changes

File	Change Summary
frontend/src/templates/GuideMainPageTemplate/GuideMainPageComponents/ConfirmationPopup/ConfirmationPopup.jsx	- Reformatted import statements to use double quotes - Added closeAfterTransition={open} to Dialog component - Improved code formatting and readability
frontend/src/templates/GuideTemplate/GuideTemplate.jsx	- Added closeAfterTransition prop to Dialog - Replaced single quotes with double quotes - No changes to component logic

Possibly Related PRs

• popup-design #290: Related changes in PopupComponent involving dialog behavior and formatting modifications

Suggested Reviewers

• thomastepi

Note: No sequence diagram was generated as the changes are primarily formatting and minor configuration adjustments that do not significantly alter the control flow or introduce complex interactions.

---

📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 0ea09b7 and 56af58e.

📒 Files selected for processing (2)

• frontend/src/templates/GuideMainPageTemplate/GuideMainPageComponents/ConfirmationPopup/ConfirmationPopup.jsx (1 hunks)
• frontend/src/templates/GuideTemplate/GuideTemplate.jsx (2 hunks)

✅ Files skipped from review due to trivial changes (1)

• frontend/src/templates/GuideTemplate/GuideTemplate.jsx

🔇 Additional comments (4)

frontend/src/templates/GuideMainPageTemplate/GuideMainPageComponents/ConfirmationPopup/ConfirmationPopup.jsx (4)

1-2: If you had one shot to get your imports right, would you seize it or just let it slip?
Switching to double quotes is consistent and improves readability. Keep up this uniform style for a clean and standardized look.

Also applies to: 3-10

---

14-14: Knees weak, arms are heavy—no more sweaty confusion with the closeAfterTransition={open} prop.
Granting the dialog a smoother close sequence preserves accessibility by avoiding abrupt removal from the DOM. This is a good move for user experience.

---

17-19: Are you sure it's time to lose yourself in the moment?
This text is straightforward and succinct. Providing a clear prompt helps users confirm their actions with confidence.

---

23-25: Confirm it before that vomit on your sweater meets mom’s spaghetti.
Labelling the “Confirm” button distinctly helps users quickly identify the final action. This is a best practice for clarity and accessibility.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

‼️ IMPORTANT
Auto-reply has been disabled for this repository in the CodeRabbit settings. The CodeRabbit bot will not respond to your replies unless it is explicitly tagged.

• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.