Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for Formik and Yup in Hint FE #478

Merged
merged 2 commits into from
Jan 14, 2025

Conversation

Kannav02
Copy link
Contributor

Describe your changes

This PR would add support for Formik and Yup to the following pages/components involved with Hint FE

HintLeftContent.jsx
Screenshot 2025-01-10 at 7 22 55 PM

HintLeftAppearance.jsx
Screenshot 2025-01-10 at 7 23 02 PM

Issue number

This PR fixes #457

Please ensure all items are checked off before requesting a review:

  • I deployed the code locally.
  • I have performed a self-review of my code.
  • I have included the issue # in the PR.
  • I have labelled the PR correctly.
  • The issue I am working on is assigned to me.
  • I didn't use any hardcoded values (otherwise it will not scale, and will make it difficult to maintain consistency across the application).
  • I made sure font sizes, color choices etc are all referenced from the theme.
  • My PR is granular and targeted to one specific feature.
  • I took a screenshot or a video and attached to this PR if there is a UI change.

@erenfn
Copy link
Collaborator

erenfn commented Jan 12, 2025

Hey, how is this issue going?

@Kannav02
Copy link
Contributor Author

Kannav02 commented Jan 13, 2025

I will put out the first draft of changes at most by tomorrow, still working on getting the UI right

Thank you!

@swoopertr swoopertr marked this pull request as ready for review January 14, 2025 13:12
@swoopertr swoopertr merged commit d084acf into bluewave-labs:master Jan 14, 2025
1 check passed
Copy link
Contributor

coderabbitai bot commented Jan 14, 2025

Caution

Review failed

The pull request is closed.

Walkthrough

The pull request introduces Formik and Yup validation for color inputs in two frontend components: HintLeftAppearance.jsx and HintLeftContent.jsx. The changes focus on implementing a validation schema for color-related form fields, specifically adding imports for Formik and Yup libraries and defining a color validation mechanism using a regular expression to ensure hex color code integrity.

Changes

File Change Summary
frontend/src/components/.../HintLeftAppearance.jsx Added Formik and Yup imports, created color regex validation schema for five color properties
frontend/src/components/.../HintLeftContent.jsx Added Formik and Yup imports, prepared an empty validation schema for future implementation

Assessment against linked issues

Objective Addressed Explanation
Implement Formik and Yup validations for Hint FE [#457]

Possibly related PRs

Suggested reviewers

  • erenfn

📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 9b3a67e and 82e5700.

📒 Files selected for processing (2)
  • frontend/src/components/HintPageComponents/HintLeftAppearance/HintLeftAppearance.jsx (1 hunks)
  • frontend/src/components/HintPageComponents/HintLeftContent/HintLeftContent.jsx (1 hunks)

Finishing Touches

  • 📝 Generate Docstrings (Beta)

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

‼️ IMPORTANT
Auto-reply has been disabled for this repository in the CodeRabbit settings. The CodeRabbit bot will not respond to your replies unless it is explicitly tagged.

  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@erenfn
Copy link
Collaborator

erenfn commented Jan 15, 2025

Hi, can you reopen this PR to develop branch? Also please leave it as Draft if you are still working on it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Formik and Yup validations for Hint FE
3 participants