-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
118 save le advertising reports #133
118 save le advertising reports #133
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left you a few comments.
Also please make sure to always run "cargo +nightly fmt" and "cargo clippy" before submitting a PR.
…upress clippy suggestion since if you used it the build would fail.
…potto216/bluer into 118-Save-LE-Advertising-Reports
…potto216/bluer into 118-Save-LE-Advertising-Reports
…potto216/bluer into 118-Save-LE-Advertising-Reports
…potto216/bluer into 118-Save-LE-Advertising-Reports
@surban I made the changes except for three requests I responded with comments. Sorry for all the commits, I was running into an odd issue where git would say:
Even though I was the only one committing to the branch. |
Thanks. |
Feel free to send a separate PR if you want to add plain text logging. |
Oh I see your point, I didn't realize the hex format isn't supported in standard JSON. |
You could try using JSON5 which seems to have hex support. But I don't know how good serde support is at the moment. |
@surban what are your thoughts on this approach?