Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

118 save le advertising reports #133

Merged
merged 21 commits into from
Mar 25, 2024
Merged

118 save le advertising reports #133

merged 21 commits into from
Mar 25, 2024

Conversation

potto216
Copy link
Contributor

@potto216 potto216 commented Mar 9, 2024

@surban what are your thoughts on this approach?

bluer-tools/src/blumon.rs Fixed Show fixed Hide fixed
bluer-tools/src/blumon.rs Fixed Show resolved Hide resolved
bluer-tools/src/blumon.rs Fixed Show resolved Hide resolved
bluer-tools/src/blumon.rs Outdated Show resolved Hide resolved
bluer-tools/src/blumon.rs Outdated Show resolved Hide resolved
bluer-tools/src/blumon.rs Outdated Show resolved Hide resolved
bluer-tools/src/blumon.rs Outdated Show resolved Hide resolved
bluer-tools/src/blumon.rs Fixed Show resolved Hide resolved
bluer-tools/src/blumon.rs Outdated Show resolved Hide resolved
bluer-tools/src/blumon.rs Outdated Show resolved Hide resolved
bluer-tools/src/blumon.rs Outdated Show resolved Hide resolved
bluer-tools/src/blumon.rs Outdated Show resolved Hide resolved
bluer-tools/src/blumon.rs Outdated Show resolved Hide resolved
Copy link
Collaborator

@surban surban left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left you a few comments.

Also please make sure to always run "cargo +nightly fmt" and "cargo clippy" before submitting a PR.

@potto216
Copy link
Contributor Author

potto216 commented Mar 24, 2024

@surban I made the changes except for three requests I responded with comments. Sorry for all the commits, I was running into an odd issue where git would say:

 ! [rejected]        118-Save-LE-Advertising-Reports -> 118-Save-LE-Advertising-Reports (non-fast-forward)
error: failed to push some refs to 'https://github.com/potto216/bluer'
hint: Updates were rejected because the tip of your current branch is behind
hint: its remote counterpart. Integrate the remote changes (e.g.
hint: 'git pull ...') before pushing again.
hint: See the 'Note about fast-forwards' in 'git push --help' for details.

Even though I was the only one committing to the branch.

@surban surban merged commit 64a264b into bluez:master Mar 25, 2024
3 checks passed
@surban
Copy link
Collaborator

surban commented Mar 25, 2024

Thanks.

@surban
Copy link
Collaborator

surban commented Mar 25, 2024

Feel free to send a separate PR if you want to add plain text logging.

@potto216
Copy link
Contributor Author

Oh I see your point, I didn't realize the hex format isn't supported in standard JSON.

@surban
Copy link
Collaborator

surban commented Mar 26, 2024

You could try using JSON5 which seems to have hex support. But I don't know how good serde support is at the moment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants