Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#4 - Login + reset password #20

Merged
merged 36 commits into from
Aug 20, 2024
Merged

#4 - Login + reset password #20

merged 36 commits into from
Aug 20, 2024

Conversation

PrabuckiDominik
Copy link
Collaborator

This should close #4 .
Added: Register and login
Implemented: Reset, forgot password and mail verification

@PrabuckiDominik
Add migration for schools_table and modify users_table
fa6ed85
@PrabuckiDominik
Add migration for schools_table and modify users_table
5fcd938
@PrabuckiDominik
Add:
cbb1f7c 
- register and login forms
- RegisterUserController and RegisterUserRequest
- ContestController
- improve user model
- add foreign key to user table
@PrabuckiDominik
Fix code style
687b8d3
@PrabuckiDominik
Add tests and SchoolFactory
13ed6bf
@PrabuckiDominik
Mail Verification
a12b833
@PrabuckiDominik
Test Mail
5370de1
@PrabuckiDominik
Add EmailVerifyController
89ab832 
Add PasswordResetLinkController
@PrabuckiDominik
Improve DatabaseSeeder and Factories
39ef29e
@PrabuckiDominik
Fix RegisterUserController
f5c1e6b 
Add and improve tests
@PrabuckiDominik
Increase bcrypt round to 12
47dddf2
@PrabuckiDominik
Add .vue for Forgot-Password
ac65257
@PrabuckiDominik
Code style fix
3fdd083
@PrabuckiDominik
Add reset password
9e87e2c
@PrabuckiDominik
Add tests for reset password
276e7f3
@PrabuckiDominik
Merge branch 'main' of https://github.com/blumilksoftware/interns2024b …
2f9ae64 
…into 4-login-+-reset-password
@PrabuckiDominik
fix code style
f742250
@PrabuckiDominik PrabuckiDominik linked an issue Aug 13, 2024 that may be closed by this pull request
Login + reset password #4
Closed
EwelinaSkrzypacz
EwelinaSkrzypacz reviewed Aug 13, 2024
View reviewed changes
Copy link
Member

@EwelinaSkrzypacz EwelinaSkrzypacz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. I think that in this situation I should see validation error

image

  1. I don't get reset password e-mail

  2. When I'm on register page and I click "Register" I should see some validation messages - now I don't see anything

app/Http/Requests/Auth/RegisterUserRequest.php Outdated Show resolved Hide resolved
@PrabuckiDominik
Add validation errors and messages
d8815a6 
Add:
 validation errors and messages
Improve:
 Controllers with requests
 Tests
kamilpiech97
kamilpiech97 requested changes Aug 19, 2024
View reviewed changes
app/Http/Controllers/PasswordResetLinkController.php Outdated Show resolved Hide resolved
app/Http/Controllers/PasswordResetLinkController.php Outdated Show resolved Hide resolved
app/Http/Requests/Auth/AuthenticateSessionRequest.php Outdated Show resolved Hide resolved
app/Http/Requests/Auth/ForgotPasswordRequest.php Outdated Show resolved Hide resolved
app/Http/Requests/Auth/RegisterUserRequest.php Outdated Show resolved Hide resolved
app/Http/Requests/Auth/ResetPasswordRequest.php Outdated Show resolved Hide resolved
app/Mail/RegistrationMail.php Outdated Show resolved Hide resolved
resources/js/Pages/Auth/Verify-Email.vue Outdated Show resolved Hide resolved
EwelinaSkrzypacz
EwelinaSkrzypacz reviewed Aug 19, 2024
View reviewed changes
Copy link
Member

@EwelinaSkrzypacz EwelinaSkrzypacz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When I reset password and I fill email that doesn't exist in database I see error

image

I think that we should give information something like "If your e-mail is in our database, you will receive email with reset password" or something like that

@PrabuckiDominik
Add validation translation files
ee5cab6 
Change to pl language in .env.example.
Change some files name into PascalCase.
Remove unused verify-email.
Remove messages from requests.
@PrabuckiDominik
Fix email error message for existing email addresses
f52cabf
@PrabuckiDominik
Merge branch 'main' of https://github.com/blumilksoftware/interns2024b …
12d2c02 
…into 4-login-+-reset-password
@PrabuckiDominik
Link frontend with backend
231188e 
Add SchoolResource
Remove unused route and pages
kamilpiech97
kamilpiech97 reviewed Aug 20, 2024
View reviewed changes
.env.example Outdated Show resolved Hide resolved
app/Http/Controllers/RegisterUserController.php Outdated Show resolved Hide resolved
app/Http/Requests/Auth/AuthenticateSessionRequest.php Outdated Show resolved Hide resolved
app/Mail/RegistrationMail.php Outdated Show resolved Hide resolved
app/Models/School.php Outdated Show resolved Hide resolved
resources/js/Pages/Auth/ResetPassword.vue Show resolved Hide resolved
resources/js/Pages/Auth/ResetPassword.vue Outdated Show resolved Hide resolved
resources/js/Pages/Home.vue Show resolved Hide resolved
resources/js/components/Home/LoginForm.vue Show resolved Hide resolved
routes/web.php Outdated Show resolved Hide resolved
kamilpiech97
kamilpiech97 previously approved these changes Aug 20, 2024
View reviewed changes
.env.example Outdated Show resolved Hide resolved
kamilpiech97
kamilpiech97 previously approved these changes Aug 20, 2024
View reviewed changes
@PrabuckiDominik PrabuckiDominik merged commit 5826b80 into main Aug 20, 2024
3 checks passed
@PrabuckiDominik PrabuckiDominik deleted the 4-login-+-reset-password branch August 20, 2024 10:25
@PrabuckiDominik PrabuckiDominik mentioned this pull request Aug 20, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EwelinaSkrzypacz EwelinaSkrzypacz EwelinaSkrzypacz left review comments

@kamilpiech97 kamilpiech97 kamilpiech97 approved these changes

@AleksandraKozubal AleksandraKozubal AleksandraKozubal approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Login + reset password
4 participants
@PrabuckiDominik @kamilpiech97 @EwelinaSkrzypacz @AleksandraKozubal