Skip to content

#87 - login page improvements #91

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 59 commits into from
Nov 7, 2024
Merged

#87 - login page improvements #91

merged 59 commits into from
Nov 7, 2024

Conversation

JokeUrSelf
Copy link
Contributor

@JokeUrSelf JokeUrSelf commented Sep 8, 2024 •
edited
Loading

Should close #94
Should close #87
Should close #30

The colors are messed up on screenshots!

  • Changed style of focused inputs
    image
  • Searchbar logic is now separated from schools data logic. Searchbar can be used anywhere in the app now.
  • Searchbar's icon changes color on focus
    image
  • Fixed the issue with overflowing autocompletetion background
  • Fixed the issue with Email autocompletetion appearing on a searchbar
  • Show/hide button for a password input added
    image
  • Checkbox now activates when clicking on a label
  • Information button works again
  • Changed the look of "Forgot password" page to match the style on a login page
    image

@JokeUrSelf
chore: add request files
03d3879
@JokeUrSelf
fix: information button
171e359
@JokeUrSelf
fix, refactor
6e9efd6
@JokeUrSelf
feat: add icon for password
d697184
@JokeUrSelf
fix: scrolling on small windows
c26b36c
@JokeUrSelf
fix: correct request from login form
d0d47fa
@JokeUrSelf
fix: change school_id name to search, eliminating a bug of treati…
1ca4942 
…ng it as an email field
@JokeUrSelf
style: change fields, refactor: externalize searchbar
a6c434a
@JokeUrSelf
fix: add missing features searchbar
6ee49dc
@JokeUrSelf
style: add icon to banner
57de718
@JokeUrSelf
style: make background effect whiter
07c2c31
@JokeUrSelf
style: adjust header padding
7ee0bda
@JokeUrSelf
style: add padding to forgot password
6ff74b2
@JokeUrSelf
build: add @vue/core and reveal.js
a72bc6b
@JokeUrSelf
refactor: remove redundant macro imports
cc4d113
@JokeUrSelf
fix: search bar autoscope clicking, style: hardcoded color value
0e797f9
@JokeUrSelf
fix: retrun search functionalities to the searchbar
6e5db3a
@JokeUrSelf
build: remove reveal.js
10a14ee
@JokeUrSelf
style: change eye color for password
70cc0ff
@JokeUrSelf
fix: overflow scroll doesn't work
dab486c
@JokeUrSelf
Merge branch 'main' of https://github.com/blumilksoftware/interns2024b …
569c3b1 
…into 87-login-page-improvements
@JokeUrSelf
fix: change "zaloguj się" to "zarejestruj się" in register form
87ef7af
This was linked to issues Sep 8, 2024
Improvements for register/login section #30
Closed
Homepage: wrap checkbox in label #87
Closed
EwelinaSkrzypacz
EwelinaSkrzypacz reviewed Sep 9, 2024
View reviewed changes
Copy link
Member

@EwelinaSkrzypacz EwelinaSkrzypacz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Can we add title to this page? Now it's a bit... empty

image

  1. Forgot password page and setting a new password page look different - please unify that

image

image

  1. Please add title to this page. Also add show/hide password button

image

@JokeUrSelf
Copy link
Contributor Author

I'll try to be more cooperative

EwelinaSkrzypacz
EwelinaSkrzypacz reviewed Oct 4, 2024
View reviewed changes
@EwelinaSkrzypacz
Copy link
Member

And if this pr closes the issue, pleas add this information to pr description

@JokeUrSelf @EwelinaSkrzypacz
Update resources/js/Pages/Guest/ResetPassword.vue
a227a09 
Co-authored-by: Ewelina Skrzypacz <56546832+EwelinaSkrzypacz@users.noreply.github.com>
EwelinaSkrzypacz
EwelinaSkrzypacz reviewed Oct 14, 2024
View reviewed changes
Copy link
Member

@EwelinaSkrzypacz EwelinaSkrzypacz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When I click "Nie pamiętam hasła" I see error

image

@JokeUrSelf
Copy link
Contributor Author

When I click "Nie pamiętam hasła" I see error

Fixed

@EwelinaSkrzypacz
Copy link
Member

Conflicts

@JokeUrSelf
Copy link
Contributor Author

@dawidrudnik please check the PR

dawidrudnik
dawidrudnik reviewed Nov 4, 2024
View reviewed changes
dawidrudnik
dawidrudnik reviewed Nov 5, 2024
View reviewed changes
@JokeUrSelf JokeUrSelf merged commit 21dd075 into main Nov 7, 2024
3 checks passed
@JokeUrSelf JokeUrSelf deleted the 87-login-page-improvements branch November 7, 2024 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dawidrudnik dawidrudnik dawidrudnik approved these changes

@EwelinaSkrzypacz EwelinaSkrzypacz EwelinaSkrzypacz approved these changes

@AleksandraKozubal AleksandraKozubal Awaiting requested review from AleksandraKozubal

@kamilpiech97 kamilpiech97 Awaiting requested review from kamilpiech97

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Email verification page - Fronted Homepage: wrap checkbox in label Improvements for register/login section
3 participants
@JokeUrSelf @EwelinaSkrzypacz @dawidrudnik