Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#36 - Ranking #99

Merged
merged 10 commits into from
Oct 28, 2024
Merged

#36 - Ranking #99

merged 10 commits into from
Oct 28, 2024

Conversation

AmonDeShir
Copy link
Collaborator

Should close #36.

Ranking - admin

image
image

Ranking - admin mobile

image
image

Ranking - user

image
image

Ranking - user mobile

image
image

Copy link
Member

@EwelinaSkrzypacz EwelinaSkrzypacz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As an admin when I publish or unpublish ranking, I have to scroll to the top to see notification - maybe page should be scrolled automatically? Bo maybe notifications should look different?

@AmonDeShir
Copy link
Collaborator Author

As an admin when I publish or unpublish ranking, I have to scroll to the top to see notification - maybe page should be scrolled automatically? Bo maybe notifications should look different?

I made the notification sticky, so it's always visible without scrolling.
image

Copy link
Member

@EwelinaSkrzypacz EwelinaSkrzypacz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should I be able to publish empty ranking? 🤔

@AmonDeShir
Copy link
Collaborator Author

Should I be able to publish empty ranking? 🤔

Fixed
image

database/seeders/UserSeeder.php Outdated Show resolved Hide resolved
tests/Feature/RankingTest.php Outdated Show resolved Hide resolved
database/seeders/UserSeeder.php Outdated Show resolved Hide resolved
database/seeders/UserSeeder.php Outdated Show resolved Hide resolved
database/seeders/UserSeeder.php Outdated Show resolved Hide resolved
database/seeders/AdminSeeder.php Outdated Show resolved Hide resolved
@AmonDeShir AmonDeShir merged commit 9d35910 into main Oct 28, 2024
3 checks passed
@AmonDeShir AmonDeShir deleted the ranking branch October 28, 2024 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ranking - Frontend
4 participants