- CRUD forms tweaks #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kamilpiech97
previously approved these changes
Sep 26, 2023
# Conflicts: # resources/js/Pages/Dashboard/Student/Index.vue # resources/js/Shared/Components/EmptyState.vue
There was a problem hiding this comment.
- On mobile the changing password form is too small.
I check this on iPhone SE resolution.
- On mobile the search is too narrow.
I check this on iPhone SE resolution.
- When I add a student with a really big index number, on the index view I see that the index number is in scientific notation.
- On edit semester form the validation message on field name is not translated correclty.
|
With number 4 its my fault |
|
@EwelinaSkrzypacz , let's worry about responsivnessof dashboard later. |
KarolZygadlo
approved these changes
Sep 27, 2023
kamilpiech97
approved these changes
Sep 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Another series of tweaks: