-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#12 - grade columns and grade crud #61
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
-
If we're checking for presence, it should remain as it currently is. But once the cell has a state (presence), any state changes should be triggered by a double click. Why? Because now we can't write negative assessment on red background.
-
When I write too long string on grades, I see error:
- We should change delete column icon from trash to x mark, because we have x mark icon in whole application.
<template #body> | ||
<TableRow v-for="student in students.data" :key="student.id"> | ||
<TableCell> | ||
{{ student.index_number }} ({{ student.first_name }} {{ student.surname }} ) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
{{ student.index_number }} ({{ student.first_name }} {{ student.surname }} ) | |
{{ student.index_number }} ({{ student.first_name }} {{ student.surname }}) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a nitpicking a bit, but I think I will change some colors:
- instead of
bg-green-300
please setbg-lime-200
- change
bg-red-300
tobg-rose-300
- set text color to
text-grey-900
This should close #12.
Added CRUD for managing grade columns in student group and adding grades for students.
Added some tests.
Preview:
Screencast.from.22-10-23.11.08.16.webm