Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#12 - grade columns and grade crud #61

Merged
merged 9 commits into from
Oct 31, 2023
Merged

#12 - grade columns and grade crud #61

merged 9 commits into from
Oct 31, 2023

Conversation

kamilpiech97
Copy link
Member

This should close #12.
Added CRUD for managing grade columns in student group and adding grades for students.
Added some tests.

Preview:

Screencast.from.22-10-23.11.08.16.webm

@kamilpiech97 kamilpiech97 requested a review from a team as a code owner October 22, 2023 09:11
@kamilpiech97 kamilpiech97 changed the title #12 - grade columns and grades crud #12 - grade columns and grade crud Oct 22, 2023
Copy link
Member

@EwelinaSkrzypacz EwelinaSkrzypacz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. If we're checking for presence, it should remain as it currently is. But once the cell has a state (presence), any state changes should be triggered by a double click. Why? Because now we can't write negative assessment on red background.

  2. When I write too long string on grades, I see error:

image

  1. We should change delete column icon from trash to x mark, because we have x mark icon in whole application.

<template #body>
<TableRow v-for="student in students.data" :key="student.id">
<TableCell>
{{ student.index_number }} ({{ student.first_name }} {{ student.surname }} )
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
{{ student.index_number }} ({{ student.first_name }} {{ student.surname }} )
{{ student.index_number }} ({{ student.first_name }} {{ student.surname }})

Copy link
Member

@EwelinaSkrzypacz EwelinaSkrzypacz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. I believe that the width of the columns should be fairly consistent. Alternatively, should we consider adjusting it based on the length of the contained text?

image

  1. Please fix warnings from dev console

image

Copy link
Member

@EwelinaSkrzypacz EwelinaSkrzypacz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Icons is too small - maybe instead of arrows we should make draggable columns>

image

  1. What a shame that we have to scroll the table, maybe we can do this something with it?

Copy link
Member

@EwelinaSkrzypacz EwelinaSkrzypacz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a nitpicking a bit, but I think I will change some colors:

  • instead of bg-green-300 please set bg-lime-200
  • change bg-red-300 to bg-rose-300
  • set text color to text-grey-900

@kamilpiech97 kamilpiech97 merged commit dc973e7 into main Oct 31, 2023
3 checks passed
@kamilpiech97 kamilpiech97 deleted the #12-grades-crud branch October 31, 2023 05:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Grades management
3 participants