#395 - CSP header #412
Merged
#395 - CSP header #412
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@kamilpiech97, are you going to open it? |
|
I think so, I wanna check that and I will open. |
EwelinaSkrzypacz
approved these changes
Jul 31, 2024
krzysztofrewak
approved these changes
Jul 31, 2024
mtracz
reviewed
Jul 31, 2024
| @@ -3,6 +3,9 @@ | |||
| <head> | |||
| <meta charset="utf-8"/> | |||
| <meta name="viewport" content="width=device-width, initial-scale=1.0, maximum-scale=1.0"/> | |||
| @if (app()->environment('production')) | |||
There was a problem hiding this comment.
I think it should check if app is in non local environment. Because on beta environment we wont be able to detect any issues related to CSP header.
There was a problem hiding this comment.
yep, sure.
I will fix that
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should close #395.
Now, when I checked https://beta.toby.blumilk.pl/. Our website has A+ score.
On production website should be the same after deploy.