Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#405 - Laravel 11 upgrade #413

Merged
merged 29 commits into from
Apr 3, 2024
Merged

#405 - Laravel 11 upgrade #413

merged 29 commits into from
Apr 3, 2024

Conversation

krzysztofrewak
Copy link
Member

@krzysztofrewak krzysztofrewak commented Mar 27, 2024

In this PR I have:

  • updated all dependencies including Laravel to new main version
  • reorganize app directories
  • reorganize Laravel structures

This should close #405.

@krzysztofrewak krzysztofrewak requested a review from a team as a code owner March 27, 2024 10:36
@krzysztofrewak
Copy link
Member Author

With last commit I removed rackbeat/laravel-ui-avatars. I replace it with really simple custom class.

mtracz
mtracz previously approved these changes Mar 28, 2024
Copy link
Member

@EwelinaSkrzypacz EwelinaSkrzypacz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. When I locally setup project, after running fresh migrations, I can't create request, because I can't choose type - I see 401 error in console.
  2. On beta I can't login - I see error in console:

image

@mtracz
Copy link
Member

mtracz commented Mar 28, 2024

@EwelinaSkrzypacz
If you run app in dev mode (npm run dev), open app via http not https.
If you run app in prod mode (npm run build) https should works.

@EwelinaSkrzypacz
Copy link
Member

On dev env I open app via http

On beta env I do nothing - just I made deploy

bootstrap/app.php Outdated Show resolved Hide resolved
@mtracz
Copy link
Member

mtracz commented Mar 28, 2024

@EwelinaSkrzypacz
Looks like beta is working after configuring trusted proxies middleware.

@EwelinaSkrzypacz
Copy link
Member

Thanks, beta is working right now - I can login and click through application.

But I have one problem - I can't create request (on local env and beta env) because I see 401 error in dev console. It's like request types don't fetch

image

Copy link
Member

@EwelinaSkrzypacz EwelinaSkrzypacz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When I deployed this branch to beta I noticed that I have role "administrator" but I didn't have any permissions to see things that admin should see, like "CV". But when I deployed branch main everything works as expected.

Copy link
Member

@EwelinaSkrzypacz EwelinaSkrzypacz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When I want to login into app (http://toby.blumilk.localhost/login) , I see error

image

composer.json Show resolved Hide resolved
@krzysztofrewak krzysztofrewak merged commit 75ecb04 into main Apr 3, 2024
5 checks passed
@krzysztofrewak krzysztofrewak deleted the laravel-11 branch April 3, 2024 09:30
Copy link

sentry-io bot commented Apr 4, 2024

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

  • ‼️ Illuminate\Database\LazyLoadingViolationException: Attempted to lazy load [user] on model [Toby\Models\VacationRequest] but lazy loading is disabled. /app/Notifications/VacationRequestsSummaryNotif... View Issue
  • ‼️ Illuminate\Database\LazyLoadingViolationException: Attempted to lazy load [user] on model [Toby\Models\VacationRequest] but lazy loading is disabled. /app/Slack/Elements/VacationRequestsAttachment.... View Issue

Did you find this useful? React with a 👍 or 👎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade to Laravel 11
4 participants