Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#457 - inactive user cleanup #461

Merged
merged 12 commits into from
Jul 12, 2024
Merged

#457 - inactive user cleanup #461

merged 12 commits into from
Jul 12, 2024

Conversation

kamilpiech97
Copy link
Member

@kamilpiech97 kamilpiech97 commented Jul 8, 2024

Should close #457.
Added gray background color for blocked users if user wanna see them on index. Added on indexes checkbox for switching visibility of inactive users.

Preview:
image

@kamilpiech97 kamilpiech97 marked this pull request as ready for review July 8, 2024 09:48
@kamilpiech97 kamilpiech97 requested a review from a team as a code owner July 8, 2024 09:48
Copy link
Member

@krzysztofrewak krzysztofrewak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's talk tomorrow about these filters. Please remind me about it.

Copy link
Member

@EwelinaSkrzypacz EwelinaSkrzypacz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about CVs, devices and benefits?
And on vacation limit page I see always the inactive user.

Copy link
Member

@EwelinaSkrzypacz EwelinaSkrzypacz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. As an admin, when I go to page with equipment I see error:

image

  1. On CV page, inactive users should be marked somehow - like gray background or so

  2. The same thing on page benefits-reports/1

  3. ON users page, inactive users have red background but on other pages gray. Can we unify it somehow?

@kamilpiech97
Copy link
Member Author

  1. As an admin, when I go to page with equipment I see error:

image

  1. On CV page, inactive users should be marked somehow - like gray background or so
  2. The same thing on page benefits-reports/1
  3. ON users page, inactive users have red background but on other pages gray. Can we unify it somehow?

1, 2, 3, 4 fixed

Copy link
Member

@EwelinaSkrzypacz EwelinaSkrzypacz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On benefits report page still we don't have marked inactive users (at least I don't have)

And I still have problem with equipment

app/Http/Controllers/EquipmentController.php Outdated Show resolved Hide resolved
app/Http/Controllers/EquipmentController.php Outdated Show resolved Hide resolved
app/Http/Controllers/ResumeController.php Show resolved Hide resolved
app/Http/Controllers/VacationLimitController.php Outdated Show resolved Hide resolved
Co-authored-by: Krzysztof Rewak <krzysztof.rewak@blumilk.pl>
@kamilpiech97 kamilpiech97 merged commit d01a022 into main Jul 12, 2024
3 checks passed
@kamilpiech97 kamilpiech97 deleted the #457-inactive-user-cleanup branch July 12, 2024 06:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make clean-up with inactive user
3 participants