-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#222 - activities crud #230
Conversation
# Conflicts: # app/Providers/Filament/AdminPanelProvider.php # composer.json # composer.lock
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- When I run
php artisan migrate:fresh --seed
I see error
As we talked with @kamilpiech97 we have to add empty folder activities
- Date on view/edit activity should be in Polish format (dd.mm.rrrr) - now it is like mm/dd/rrrr
- AFAIK the admin panel will be only in Polish, so we should show on index activities list title in Polish (now we show in English)
1, 2. fixed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With @kamilpiech97 we decided to leave dates to next pr - on some browser works (Kamil has Google Chrome in English and date display is in format dd.mm.yyyy, but on mine browser - Google Chrome in English also - I have format mm/dd/rrrr) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Filters for dates doesn't work - for example I created an activity with publish date 11.04.2024 and I choose filters from 08.04.2024 to 08.04.2024, so I shouldn't see the activity, but it is
-
I think we should add sorting - by date asc and desc?
-
"The data publikacji field is required unless opublikowane is in 1." - this is validation message, when user check "Opublikowane" but doesn't fill date - can we write this somehow better? Like "Pole data publikacji jest wymagane, jeżeli została zaznaczona opcja Opublikowane" or something like that. We can also leave this to pr related to translations, it can be treated as reminder.
-
Can we add search input?
1, 2. fixed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Should close #222.
Added Activity model and CRUD views in admin panel. Some of activity fields are translatable via laravel-translatable.
Preview of create view: