Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

- admin panel i18n #236

Merged
merged 19 commits into from
Apr 23, 2024
Merged

- admin panel i18n #236

merged 19 commits into from
Apr 23, 2024

Conversation

kamilpiech97
Copy link
Member

@kamilpiech97 kamilpiech97 commented Apr 10, 2024 •
edited
Loading

Added default language for admin dashboard.
Added translated labels for existing resources.
Added tests.

@kamilpiech97
- added filament package and first crud - user resource
38351b9
@kamilpiech97
- cdf
32ff3a9
@kamilpiech97
#222 - activity crud with multilanguage
20315aa
@kamilpiech97
Merge branch 'main' into #222-activities-crud
7a94c24 
# Conflicts:
#	app/Providers/Filament/AdminPanelProvider.php
#	composer.json
#	composer.lock
@kamilpiech97
#222 - merged main
2c50d21
@kamilpiech97
- fixes
0105182
@kamilpiech97
#222 - activities crud update
2d359d3
@kamilpiech97
#222 - added factory and seeder
aef32ef
@kamilpiech97
- cr fix
ab49ad3
@kamilpiech97
- cr fix
3b46137
@kamilpiech97
#222 - cr fixes
df76e13
@kamilpiech97
- fixes
1b2af49
@kamilpiech97
- wip with i18n of admin panel
d55a5fc
@kamilpiech97
Merge branch 'main' into admin-panel-i18n
48f8bed 
# Conflicts:
#	app/Filament/Resources/ActivityResource.php
#	app/Models/Activity.php
#	config/app.php
#	database/factories/ActivityFactory.php
#	database/migrations/2024_04_09_091339_create_activities_table.php
@kamilpiech97
- fixes and bumps
0e20dce
@kamilpiech97 kamilpiech97 marked this pull request as ready for review April 19, 2024 07:20
@kamilpiech97 kamilpiech97 requested a review from a team as a code owner April 19, 2024 07:20
EwelinaSkrzypacz
EwelinaSkrzypacz reviewed Apr 19, 2024
View reviewed changes
Copy link
Member

@EwelinaSkrzypacz EwelinaSkrzypacz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. This translation sounds a bit awkward

image

  1. "Published from" and "published to" is not translated

image

  1. Alb\so format date is bad - we should have dd.mm.yyyy (now we have mm/dd/yyyy)

and calendar is also in English

@kamilpiech97
Copy link
Member Author

  1. This translation sounds a bit awkward

image

  1. "Published from" and "published to" is not translated

image

  1. Alb\so format date is bad - we should have dd.mm.yyyy (now we have mm/dd/yyyy)

and calendar is also in English

  1. changed rule
  2. translated
  3. changed

EwelinaSkrzypacz
EwelinaSkrzypacz reviewed Apr 22, 2024
View reviewed changes
Copy link
Member

@EwelinaSkrzypacz EwelinaSkrzypacz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. When I fill form on create activity page like on screenshot below (title, subtitle, description, but only in Polish) I see error

image

  1. I have still calendar in English (and date format) - I have Chrome in English and I see formatted date mm/dd/yyyy, but on Firefox in Polish I have format like dd . mm . rrrr (and yes, with spaces between dots)

image

image

EwelinaSkrzypacz
EwelinaSkrzypacz approved these changes Apr 23, 2024
View reviewed changes
Copy link
Member

@EwelinaSkrzypacz EwelinaSkrzypacz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I give approve, because dates works - it's browser fault.

@kamilpiech97 kamilpiech97 merged commit 8215989 into main Apr 23, 2024
3 checks passed
@kamilpiech97 kamilpiech97 deleted the admin-panel-i18n branch April 23, 2024 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KarolZygadlo KarolZygadlo KarolZygadlo approved these changes

@EwelinaSkrzypacz EwelinaSkrzypacz EwelinaSkrzypacz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kamilpiech97 @EwelinaSkrzypacz @KarolZygadlo