Skip to content

#225 - case studies#239

Merged
kamilpiech97 merged 29 commits intomainfrom
#225-case-studies
Apr 25, 2024
Merged

#225 - case studies#239
kamilpiech97 merged 29 commits intomainfrom
#225-case-studies

Conversation

@kamilpiech97
Copy link
Copy Markdown
Member

@kamilpiech97 kamilpiech97 commented Apr 19, 2024

Should close #225.
Added case study model and CRUD views in admin panel. Some of case study fields are translatable via laravel-translatable.

Preview:
image

@kamilpiech97 kamilpiech97 marked this pull request as ready for review April 23, 2024 09:32
@kamilpiech97 kamilpiech97 requested a review from a team as a code owner April 23, 2024 09:32
Copy link
Copy Markdown
Member

@EwelinaSkrzypacz EwelinaSkrzypacz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When I create a case study without template I see error

image

kamilpiech97 and others added 3 commits April 23, 2024 14:52
Co-authored-by: Ewelina Skrzypacz <56546832+EwelinaSkrzypacz@users.noreply.github.com>
Copy link
Copy Markdown
Member

@EwelinaSkrzypacz EwelinaSkrzypacz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. When case study has no template, on index we should add dash, becaouse now it looks empty

image

  1. When I edit case study - for example title field I have to refresh index to see changes - is it okay for us?

Flow:

You have a list of case studies with the title "best title ever" -> I edit this case study and give the title "Case study 1" ->click "Save" -> then "Cancel" to go back to the case study list page -> I still see "best title ever" -> when I refresh the page, only then do I see "Case study 1"

@kamilpiech97
Copy link
Copy Markdown
Member Author

  1. When case study has no template, on index we should add dash, becaouse now it looks empty

image

  1. When I edit case study - for example title field I have to refresh index to see changes - is it okay for us?

Flow:

You have a list of case studies with the title "best title ever" -> I edit this case study and give the title "Case study 1" ->click "Save" -> then "Cancel" to go back to the case study list page -> I still see "best title ever" -> when I refresh the page, only then do I see "Case study 1"

1, 2 fixed

@kamilpiech97 kamilpiech97 merged commit 669f728 into main Apr 25, 2024
@kamilpiech97 kamilpiech97 deleted the #225-case-studies branch April 25, 2024 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Dashboard] Case studies

3 participants