Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#228 - users CRUD #240

Merged
merged 9 commits into from
Apr 26, 2024
Merged

#228 - users CRUD #240

merged 9 commits into from
Apr 26, 2024

Conversation

kamilpiech97
Copy link
Member

@kamilpiech97 kamilpiech97 commented Apr 23, 2024

Should close #228.
Added possibility of creating and editing users.
Added roles for users.

Preview:
image

kamilpiech97 added a commit that referenced this pull request Apr 24, 2024
kamilpiech97 added a commit that referenced this pull request Apr 25, 2024
* - added filament package and first crud - user resource

* - cdf

* #222 - activity crud with multilanguage

* #222 - merged main

* - fixes

* #222 - activities crud update

* #222 - added factory and seeder

* - cr fix

* - cr fix

* #222 - cr fixes

* - fixes

* - wip with i18n of admin panel

* - fixes and bumps

* - fixes

* - composer update

* - updated workflow

* #225 - added case studies resource and related stuff

* #225 - fixes

* - fix

* - merged main

* #225 - factory added

* Update app/Filament/Resources/CaseStudyResource.php

Co-authored-by: Ewelina Skrzypacz <56546832+EwelinaSkrzypacz@users.noreply.github.com>

* #240 - cr fix

* #225 - added base actions

* #225 - cr fix

---------

Co-authored-by: Ewelina Skrzypacz <56546832+EwelinaSkrzypacz@users.noreply.github.com>
# Conflicts:
#	app/Filament/Resources/UserResource/Pages/EditUser.php
@kamilpiech97 kamilpiech97 marked this pull request as ready for review April 25, 2024 08:51
@kamilpiech97 kamilpiech97 requested a review from a team as a code owner April 25, 2024 08:51
Copy link
Member

@EwelinaSkrzypacz EwelinaSkrzypacz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. When I change admin's name and password, I see error

image

  1. I'm wondering, if we need some filters/sorting, but I'm not sure that we will have a lot of users to make that

Copy link
Member

@EwelinaSkrzypacz EwelinaSkrzypacz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When I'm logged as an admin, I can't edit my activity:

image

But on edit view I can and after that I have no access to panel

image

@kamilpiech97
Copy link
Member Author

When I'm logged as an admin, I can't edit my activity:

image

But on edit view I can and after that I have no access to panel

image

Fixed

KarolZygadlo
KarolZygadlo previously approved these changes Apr 26, 2024
@kamilpiech97 kamilpiech97 merged commit 6ffc040 into main Apr 26, 2024
2 checks passed
@kamilpiech97 kamilpiech97 deleted the #228-users-crud branch April 26, 2024 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Dashboard] Users
4 participants