#295 - photoreel & updates #335
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AleksandraKozubal
changed the title
AleksandraKozubal
changed the title
AleksandraKozubal
changed the title
There was a problem hiding this comment.
- When I run
php artisan migrateI see error
After running php artisan migrate:fresh it works
- After running
php artisan migrate:fresh --seedimages in reference section don't display
When I add a reference in admin panel without photo (to see placeholder image) it works
- Admin panel -> references -> create -> when I don't choose sex and click "Utwórz" I see error in console and reference is not created
- When I go to "O firmie" page I see error in console
- "O firmie" page - text under title "Nasze wartości" is smaller that text under title "Nasza misja". We want like that?
1.That happened bc you had old database records that didn't contain 'sex' column. Since this last |
kamilpiech97
requested changes
Aug 30, 2024
Comment on lines
6
to
13
| @php | ||
| $photoPath = (file_exists(storage_path('app/public/' . $reference->photo)) && !!$reference->photo) | ||
| ? asset('storage/' . $reference->photo) | ||
| : null; | ||
| $placeholder = $reference->sex === 'female' | ||
| ? asset('graphics/placeholders/female.svg') | ||
| : asset('graphics/placeholders/male.svg'); | ||
| @endphp |
There was a problem hiding this comment.
Suggested change
| @php | |
| $photoPath = (file_exists(storage_path('app/public/' . $reference->photo)) && !!$reference->photo) | |
| ? asset('storage/' . $reference->photo) | |
| : null; | |
| $placeholder = $reference->sex === 'female' | |
| ? asset('graphics/placeholders/female.svg') | |
| : asset('graphics/placeholders/male.svg'); | |
| @endphp | |
| @php | |
| $photoPath = (file_exists(storage_path('app/public/' . $reference->photo)) && !!$reference->photo) | |
| ? asset('storage/' . $reference->photo) | |
| : null; | |
| $placeholder = $reference->sex === 'female' | |
| ? asset('graphics/placeholders/female.svg') | |
| : asset('graphics/placeholders/male.svg'); | |
| @endphp |
Let's do that on backend
Comment on lines
137
to
143
| $main2PhotoPath = (file_exists(storage_path('app/public/' . $references[$main2]->photo)) && !!$references[$main2]->photo) | ||
| ? asset('storage/' . $references[$main2]->photo) | ||
| : null; | ||
| $main2Placeholder = $references[$main2]->sex === 'female' | ||
| ? asset('graphics/placeholders/female.svg') | ||
| : asset('graphics/placeholders/male.svg'); | ||
| @endphp |
kamilpiech97
approved these changes
Aug 30, 2024
EwelinaSkrzypacz
approved these changes
Aug 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed:
-icons: replacet a few icons from .svg to html way of usage - left only those that we change accent color + from main page case study
It should close #295.