Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#306 - add carbon project #336

Merged
merged 6 commits into from
Sep 2, 2024
Merged

#306 - add carbon project #336

merged 6 commits into from
Sep 2, 2024

Conversation

AleksandraKozubal
Copy link
Member

@AleksandraKozubal AleksandraKozubal commented Aug 30, 2024 •
edited
Loading

Desktop design

There is no mobile design but it based on previous designs, so it's also for review.

@AleksandraKozubal AleksandraKozubal marked this pull request as ready for review August 30, 2024 11:03
@AleksandraKozubal AleksandraKozubal requested a review from a team as a code owner August 30, 2024 11:03
EwelinaSkrzypacz
EwelinaSkrzypacz reviewed Aug 30, 2024
View reviewed changes
Copy link
Member

@EwelinaSkrzypacz EwelinaSkrzypacz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. For me this picture is a bit blurred

image

image

on design this text is in two lines (look at the screenshot at no 1)
on design the title is split into two lines (look at the screenshot at no 2)

@AleksandraKozubal
Copy link
Member Author

  1. For me this picture is a bit blurred

image

image

on design this text is in two lines (look at the screenshot at no 1) on design the title is split into two lines (look at the screenshot at no 2)

  1. Did issue for that bc situation occur in all projects. Update projects' images #338
    2.Done

AleksandraKozubal and others added 2 commits September 2, 2024 08:56
@AleksandraKozubal @EwelinaSkrzypacz
Update lang/en/projects.php
8f317e1 
Co-authored-by: Ewelina Skrzypacz <56546832+EwelinaSkrzypacz@users.noreply.github.com>
@AleksandraKozubal
img update
3317762
@AleksandraKozubal AleksandraKozubal merged commit 9d3ab84 into main Sep 2, 2024
3 checks passed
@AleksandraKozubal AleksandraKozubal deleted the #306-carbon-footprint--app branch September 2, 2024 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dawidrudnik dawidrudnik dawidrudnik approved these changes

@EwelinaSkrzypacz EwelinaSkrzypacz EwelinaSkrzypacz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AleksandraKozubal @dawidrudnik @EwelinaSkrzypacz