Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

- add max file size #387

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

- add max file size #387

wants to merge 2 commits into from

Conversation

EwelinaSkrzypacz
Copy link
Member

In this pr I added to php.ini and nginx.conf max size of files

@EwelinaSkrzypacz EwelinaSkrzypacz marked this pull request as ready for review October 29, 2024 11:42
@EwelinaSkrzypacz EwelinaSkrzypacz requested a review from a team as a code owner October 29, 2024 11:42
environment/dev/app/php.ini Outdated Show resolved Hide resolved
@krzysztofrewak
Copy link
Member

What happened? As far as I don't have no problem with changing things like this, I'm little worried about 3MB photos on website.

@EwelinaSkrzypacz
Copy link
Member Author

EwelinaSkrzypacz commented Oct 29, 2024

What happened? As far as I don't have no problem with changing things like this, I'm little worried about 3MB photos on website.

Kasia had a problem with uploading photo ~1.5 MB - she couldn't add a photo because of its size - log on server says that client intended to send too large body: 1481797 bytes

@mtracz
Copy link
Member

mtracz commented Oct 29, 2024

Defaults:
PHP:

  • post_max_size = 8M
  • upload_max_filesize = 2M

Nginx:

  • client_max_body_size = 1m;

So it was blocked by Nginx. I think we can bump client_max_body_size to 2m.

@EwelinaSkrzypacz
Copy link
Member Author

Defaults: PHP:

  • post_max_size = 8M
  • upload_max_filesize = 2M

Nginx:

  • client_max_body_size = 1m;

So it was blocked by Nginx. I think we can bump client_max_body_size to 2m.

Done. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants