Deallocate BumpVec on drop and into_iter, shrink on into_*slice
#33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bluurryy
added
enhancement
bluurryy
changed the title
BumpVec on drop, shrink on into_*sliceBumpVec on drop and into_iter, shrink on into_*slice
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently
BumpVecdoes not attempt to deallocate on drop nor when callinginto_*slice. This is unexpected. This is unlikeVecorMutBumpVecwhich deallocate on drop (MutBumpVecnever actually bumps the pointer).It's better if it does deallocate and shrink by default. You can still get a slice without any shrinking via
into_fixed_vec().into_boxed_slice().Todo
IntoIter