Skip to content

add some requested comments #1492

add some requested comments

add some requested comments #1492

Triggered via push October 4, 2024 18:32
Status Success
Total duration 3m 14s
Artifacts

ci.yaml

on: push
Fit to window
Zoom out
Zoom in

Annotations

10 errors and 2 warnings
lint: logging/logging.go#L29
undefined: logrusr (typecheck)
lint: internal/httpclient/httpclient_test.go#L8
"net/url" imported and not used (typecheck)
lint: providers/asrockrack/mock_test.go#L62
undefined: logrusr (typecheck)
lint: providers/rpc/http_test.go#L43
missing type in composite literal (typecheck)
lint: providers/rpc/http_test.go#L70
missing type in composite literal (typecheck)
lint: providers/rpc/http_test.go#L113
missing type in composite literal (typecheck)
lint
undefined: min (typecheck)
lint
undefined: max (typecheck)
lint
undefined: max (typecheck)
lint
serviceroot.SetClient undefined (type Service has no field or method SetClient) (typecheck)
test
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/checkout@v3, actions/setup-go@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
lint
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/checkout@v3, actions/setup-go@v3, golangci/golangci-lint-action@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/