supermicro/firmware: support firmware installs on BMCs running older firmware #339
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…re <=1.23.06 The older firmware expects Host headers to be in a certain format (without the port) and it expects a Referrer. The firmware upload endpoint expects the multipart header slightly different as well. Tested this change works on the newer firmware as well.
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #339 +/- ##
==========================================
+ Coverage 42.56% 42.59% +0.02%
==========================================
Files 44 44
Lines 3667 3679 +12
==========================================
+ Hits 1561 1567 +6
- Misses 1930 1933 +3
- Partials 176 179 +3
☔ View full report in Codecov by Sentry. |
diogomatsubara
approved these changes
Jul 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
support firmware installs on BMCs running firmware <= 1.23.06
The older firmware expects Host headers to be in a certain format (without the port) and it expects a Referrer header. The firmware upload endpoint expects the multipart header slightly different as well.
Tested this change works on the newer firmware (1.74.x) as well.
What does this PR implement/change/remove?
Checklist
The HW vendor this change applies to (if applicable)
The HW model number, product name this change applies to (if applicable)
The BMC firmware and/or BIOS versions that this change applies to (if applicable)
What version of tooling - vendor specific or opensource does this change depend on (if applicable)
Description for changelog/release notes