-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
support BootProgress on SMC X12/X13 #396
Conversation
Read through the changes, this lgtm. I'll have to add those functions to x13.go after I rebase on top of this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems correct
I think I've addressed all requests as of the latest commit. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
What does this PR implement/change/remove?
Add support for using redfish to retrieve the BootProgress from X12/X13 model servers. One of my concerns is that the version of the BMC software determines the redfish version, which can complicate the operational side of things.
This is a draft to get some consensus around my approach so far.
Checklist
The HW vendor this change applies to (if applicable)
SMC
The HW model number, product name this change applies to (if applicable)
X12 (so far)
The BMC firmware and/or BIOS versions that this change applies to (if applicable)
What version of tooling - vendor specific or opensource does this change depend on (if applicable)
Description for changelog/release notes