Conversation
…gOfWar - Исправлена утечка дочерних процессов: хранение Child + Drop (try_wait/kill/wait) - Добавлен TimeoutWriter для stdin — устранён потенциальный deadlock - EOF от подпроцесса возвращает UnexpectedEof вместо пустой строки - Заменены unwrap() на take().ok_or_else() при захвате stdout/stdin - impl Default для PrisonerDilemma и TugOfWar - Выровнены имена параметров PrisonerDilemma::new() с полями структуры - Валидация --iters >= 1, префикс left/right player error в ошибках - Исправлены doc-комментарии (Player, Game, PrisonerDilemma, TugOfWar) - Добавлено 7 юнит-тестов для TugOfWar - Исправлены Python-примеры: flush=True, корректный протокол evil.py и p1.py - Добавлено description в Cargo.toml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SubprocessPlayerтеперь хранитChildи реализуетDropс корректным завершением (try_wait-kill-wait)TimeoutWriterдля stdin подпроцессов - устраняет потенциальный deadlock при заполнении pipe-буфераUnexpectedEofвместо пустой строки.unwrap()на.take().ok_or_else()при захвате stdout/stdinPrisonerDilemma::default()иTugOfWar::default()реализованы какimpl Default(Clippyshould_implement_trait)PrisonerDilemma::new()с полями структуры--iters >= 1черезvalue_parserleft/right player error:в сообщения об ошибкахTugOfWarflush=Trueво всех скриптах,evil.pyпереписан с корректным протоколом,p1.pyпереписан с отслеживанием энергииdescriptionвCargo.toml