Skip to content
This repository has been archived by the owner on Jul 11, 2024. It is now read-only.

Merging getScreenShot and takeSnapshot methods #178

Merged
merged 3 commits into from
Jul 8, 2024

Conversation

ggalambas
Copy link
Collaborator

This has the goal of reducing the AtlasController interface, as both methods would do the same for different Map Providers.

The previous parameters x and y are now the anchor parameter of the viewpoint. The previous width and height are now the size. Example:

// old
final screenshot = await atlasController.getScreenShot(
  x: 0,
  y: 1,
  width: 200,
  height: 300
);

// new
final screenshot = await atlasController.getScreenShot(
  context: context,
  size: Size(200, 300),
  viewpoint: Viewpoint(
    anchor: ScreenCoordinates(x: 0, y: 1),
  ),
);

kelryazevedo
kelryazevedo previously approved these changes Jul 8, 2024
@kelryazevedo kelryazevedo merged commit 2c7a9ef into master Jul 8, 2024
2 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants