Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fix db override #1384

Merged
merged 1 commit into from
Apr 8, 2024
Merged

fix: fix db override #1384

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions store/sqldb/object_integrity.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -410,9 +410,12 @@ func (s *SpDBImpl) SetReplicatePieceChecksum(objectID uint64, segmentIdx uint32,
}
result = s.db.Create(insertPieceHash)
if result.Error != nil && MysqlErrCode(result.Error) == ErrDuplicateEntryCode {
//return nil
result = s.db.Save(insertPieceHash)
return result.Error
// If all columns are identical to previous, the db.Save will also encounter ErrDuplicateEntryCode, then it should skip.
err = s.db.Save(insertPieceHash).Error
if MysqlErrCode(err) == ErrDuplicateEntryCode {
return nil
}
return err
}
if result.Error != nil || result.RowsAffected != 1 {
err = fmt.Errorf("failed to insert piece hash record: %s", result.Error)
Expand Down
Loading