Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(devnet): fix devent after merge 1.3.0 #123

Merged

Conversation

welkin22
Copy link
Contributor

Description

After the upstream merge of v1.3.0, my PR (#73) for starting devnet locally no longer works. We need to be able to start devnet locally, so I made fixes based on the code from upstream merge v1.3.0.

Rationale

The biggest change is the process of contract deployment, where the upstream code uses Foundry instead of Hardhat. I have done a lot of learning and adaptation work on this. I have adapted it to work on the BSC network.

Example

The method used by devnet is the same as before, now in addition to using make devnet-up-deploy, you can also use make devnet-up to start devnet.

Changes

Notable changes:

  • Modify python script to start devnet
  • Modify dockercompose file to start devnet
  • There was some code conflict in the metrics of batcher and proposer, I resolved it
  • The last line of the DialEthClientWithTimeoutAndFallback method referenced the wrong variable, I corrected it
  • The deployment contract did not adapt to the chainId of bsc devnet, I added bsc adaptation

@bnoieh bnoieh merged commit 480dac4 into bnb-chain:merge-upstream-v1.3.0 Feb 21, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants