-
Notifications
You must be signed in to change notification settings - Fork 163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(op-node): alchemy as rpc node for opbnb #229
Conversation
@Eoous Hi, please fix the broken unit tests first. |
@welkin22 How about deleting the test cases for alchemy? Currently alchemy only support standard methods and no need to do fallback test In addition there're some timers for response required delay, they would print warn or error if use third-party service |
Yes, these test cases are no longer needed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
We'll put this pull request on hold as we're communicating with Alchemy to add support for the missing APIs in their BSC endpoint. |
That's great |
Description
Fix: #228
Changes
When using alchemy as
L1_RPC_KIND
: