fix(op-node): l1 client chan stuck when closed in ELSync mode #241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
welkin22
changed the title
bnoieh
approved these changes
Sep 10, 2024
owen-reorg
approved these changes
Sep 10, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixed the issue where the node might get stuck in the l1 client shutdown function when the node is in engine sync mode during shutdown.
Rationale
When the node has not yet fully synchronized and was in engine sync mode, the
GoOrUpdatePreFetchReceiptsmethod is not executed. At this time, the done channel of the l1 client has no consumers. If the node is closed at this moment, it will get stuck at the l1 client close operation.If I simply close the done channel, a
panic: Log in goroutine after Test_xxx has completedissue will occur during e2e testing. I must ensure that the done channel is truly closed before the close method returns.Example
none
Changes
Notable changes:
preFetchReceiptsClosedChanto ensure that everything is closed before returning from the Close functionisPreFetchReceiptsRunningto ensure that the node does not get stuck during shutdown when in Engine Sync mode.