fix: zero block reward issue (#60)

bnb-chain · Jul 10, 2024 · e11ee48 · e11ee48
1 parent e2846d7
commit e11ee48
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/crates/bsc/evm/src/execute.rs b/crates/bsc/evm/src/execute.rs
@@ -585,7 +585,7 @@ where
         let nonce = evm.db_mut().basic(sender).unwrap().unwrap_or_default().nonce;
         transaction.set_nonce(nonce);
         let hash = transaction.signature_hash();
-        if hash != system_txs[0].signature_hash() {
+        if system_txs.is_empty() || hash != system_txs[0].signature_hash() {
             debug!("unexpected transaction: {:?}", transaction);
             for tx in system_txs.iter() {
                 debug!("left system tx: {:?}", tx);

diff --git a/crates/bsc/evm/src/post_execution.rs b/crates/bsc/evm/src/post_execution.rs
@@ -280,6 +280,11 @@ where
         let (mut block_reward, transition) = system_account.drain_balance();
         self.state.apply_transition(vec![(SYSTEM_ADDRESS, transition)]);
 
+        // if block reward is zero, no need to distribute
+        if block_reward == 0 {
+            return Ok(());
+        }
+
         let balance_increment = HashMap::from([(validator, block_reward)]);
         self.state
             .increment_balances(balance_increment)