feat: add step size check for bsc stage sync #151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pythonberg1997
force-pushed
the
develop
branch
from
e08fcbe
to
a4d9065
Compare
pythonberg1997
changed the base branch from
develop
to
merge/upstream_v1.0.7
pythonberg1997
force-pushed
the
develop
branch
2 times, most recently
from
1d61f3f
to
e27e2c3
Compare
j75689
force-pushed
the
merge/upstream_v1.0.7
branch
2 times, most recently
from
4e249f1
to
d1a9d9f
Compare
pythonberg1997
force-pushed
the
develop
branch
from
e27e2c3
to
9495fa1
Compare
pythonberg1997
force-pushed
the
develop
branch
from
9495fa1
to
ebfb91b
Compare
forcodedancing
approved these changes
Sep 29, 2024
pythonberg1997
force-pushed
the
develop
branch
2 times, most recently
from
f271fd2
to
2e309b4
Compare
pythonberg1997
force-pushed
the
develop
branch
from
2e309b4
to
14dfa4d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pr is to add step size check for bsc stage sync
Rationale
Sometimes, when the node's sync height is greater than the merkle clean threshold from the latest block height, but not significantly so, performing stage sync in batches (to avoid rebuilding the merkle trie) can be faster than syncing to the highest block all at once.
Example
add an example CLI or API response...
Changes
Notable changes:
Potential Impacts