add URLSearchParams support by Monti-27 · Pull Request #5040 · boa-dev/boa

Monti-27 · 2026-03-13T16:26:19Z

Adds URLSearchParams and wires up URL.searchParams.

This also fixes the constructor path for iterable inputs, handles explicit undefined correctly in the two-argument has() and delete() overloads, adds runtime coverage, and re-enables the skipped URL WPT case.

Tests:

cargo test -p boa_runtime --lib
cargo test --manifest-path tests/wpt/Cargo.toml url -- --nocapture
cargo clippy -p boa_runtime --all-features --all-targets -- -D warnings

github-actions · 2026-03-13T16:36:51Z

Test262 conformance changes

Test result	main count	PR count	difference
Total	52,963	52,963	0
Passed	50,073	49,935	-138
Ignored	2,072	2,207	+135
Failed	818	821	+3
Panics	0	0	0
Conformance	94.54%	94.28%	-0.26%

Broken tests (3):

test/intl402/DateTimeFormat/prototype/toStringTag/toStringTag.js (previously Passed)
test/intl402/DateTimeFormat/prototype/toStringTag/toString.js (previously Passed)
test/intl402/Number/prototype/toLocaleString/throws-same-exceptions-as-NumberFormat.js (previously Passed)

Tested main commit: 0698e7063866a1b40be043a1089be43d3224db4b
Tested PR commit: a594311f4748c1f5461953ea54b30877a73f8538
Compare commits: 0698e70...a594311

Monti-27 · 2026-03-14T14:54:01Z

@jedel1043 can you please review this
thank you !!

core/runtime/src/url.rs

Monti-27 · 2026-03-17T09:31:56Z

@jedel1043 updated this. searchParams is now created during URL construction and the getter just returns the same object.

core/runtime/src/url.rs

jedel1043 · 2026-03-17T18:20:07Z

core/runtime/src/url.rs

+#[derive(Debug, Clone)]
+struct OptionalArg(Option<JsValue>);
+
+impl<'a> TryFromJsArgument<'a> for OptionalArg {
+    fn try_from_js_argument(
+        _: &'a JsValue,
+        rest: &'a [JsValue],
+        _: &mut Context,
+    ) -> JsResult<(Self, &'a [JsValue])> {
+        match rest.split_first() {
+            Some((first, rest)) => Ok((Self(Some(first.clone())), rest)),
+            None => Ok((Self(None), rest)),
+        }
+    }
+}


Wondering about this implementation. Was Option<JsValue> not enough for this? It will additionally automatically map undefined to None, so if that's the correct behaviour it would be better to use Option

core/runtime/src/url.rs

Monti-27 · 2026-03-17T18:43:41Z

give me 5 mins I'll clutch this :))

Monti-27 · 2026-03-17T19:04:12Z

also fixed the clippy failure from the missing errors docs on the Rust side URL constructors

jedel1043 · 2026-03-18T14:38:19Z

core/runtime/src/url.rs

+    done: bool,
+}
+
+impl UrlSearchParamsIterator {


This could also be a class IMO

codecov · 2026-03-18T15:00:38Z

Codecov Report

❌ Patch coverage is 81.66189% with 64 lines in your changes missing coverage. Please review.
✅ Project coverage is 59.37%. Comparing base (6ddc2b4) to head (a594311).
⚠️ Report is 884 commits behind head on main.

Files with missing lines	Patch %	Lines
core/runtime/src/url.rs	81.66%	64 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff             @@
##             main    #5040       +/-   ##
===========================================
+ Coverage   47.24%   59.37%   +12.12%     
===========================================
  Files         476      563       +87     
  Lines       46892    63095    +16203     
===========================================
+ Hits        22154    37462    +15308     
- Misses      24738    25633      +895

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

implement url search params

b40abc6

Monti-27 requested a review from a team as a code owner March 13, 2026 16:26

Monti-27 mentioned this pull request Mar 13, 2026

Implement URL.searchParams and URLSearchParams #5039

Closed

Monti-27 closed this Mar 13, 2026

Monti-27 deleted the url-searchparams-clean branch March 13, 2026 17:18

fix url search params

6168ca1

Monti-27 reopened this Mar 13, 2026

Monti-27 changed the title ~~Implement URL.searchParams and URLSearchParams~~ add URLSearchParams support Mar 13, 2026

Monti-27 and others added 3 commits March 13, 2026 22:55

add url search params tests

91b48b6

Merge branch 'main' into url-searchparams-clean

b21b76e

Merge branch 'main' into url-searchparams-clean

ba52798

jedel1043 requested changes Mar 16, 2026

View reviewed changes

core/runtime/src/url.rs Outdated Show resolved Hide resolved

jedel1043 added A-Enhancement New feature or request Waiting On Author Waiting on PR changes from the author C-Runtime Issues and PRs related to Boa's runtime features labels Mar 16, 2026

update url search params init

2fa3af5

github-actions bot added Waiting On Review Waiting on reviews from the maintainers C-Tests Issues and PRs related to the tests. C-Builtins PRs and Issues related to builtins/intrinsics and removed Waiting On Review Waiting on reviews from the maintainers labels Mar 17, 2026

Monti-27 requested a review from jedel1043 March 17, 2026 17:41

jedel1043 requested changes Mar 17, 2026

View reviewed changes

fix url review comments

a594311

Monti-27 requested a review from jedel1043 March 17, 2026 19:03

jedel1043 reviewed Mar 18, 2026

View reviewed changes

core/runtime/src/url.rs

done: bool,

}

impl UrlSearchParamsIterator {

Copy link

Member

jedel1043 Mar 18, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This could also be a class IMO

jedel1043 added Waiting On Review Waiting on reviews from the maintainers and removed Waiting On Author Waiting on PR changes from the author labels Mar 18, 2026

Monti-27 requested a review from jedel1043 March 18, 2026 14:49

jedel1043 added Waiting On Author Waiting on PR changes from the author and removed Waiting On Review Waiting on reviews from the maintainers labels Mar 18, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

add URLSearchParams support#5040

add URLSearchParams support#5040
Monti-27 wants to merge 7 commits intoboa-dev:mainfrom
Monti-27:url-searchparams-clean

Monti-27 commented Mar 13, 2026 •

edited

Loading

Uh oh!

github-actions bot commented Mar 13, 2026 •

edited

Loading

Uh oh!

Monti-27 commented Mar 14, 2026 •

edited

Loading

Uh oh!

Uh oh!

Monti-27 commented Mar 17, 2026

Uh oh!

Uh oh!

jedel1043 Mar 17, 2026

Uh oh!

Uh oh!

Uh oh!

Monti-27 commented Mar 17, 2026

Uh oh!

Monti-27 commented Mar 17, 2026

Uh oh!

jedel1043 Mar 18, 2026

Uh oh!

codecov bot commented Mar 18, 2026 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

Monti-27 commented Mar 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Mar 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Test262 conformance changes

Uh oh!

Monti-27 commented Mar 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Monti-27 commented Mar 17, 2026

Uh oh!

Uh oh!

jedel1043 Mar 17, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Monti-27 commented Mar 17, 2026

Uh oh!

Monti-27 commented Mar 17, 2026

Uh oh!

jedel1043 Mar 18, 2026

Choose a reason for hiding this comment

Uh oh!

codecov bot commented Mar 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Monti-27 commented Mar 13, 2026 •

edited

Loading

github-actions bot commented Mar 13, 2026 •

edited

Loading

Monti-27 commented Mar 14, 2026 •

edited

Loading

codecov bot commented Mar 18, 2026 •

edited

Loading