feat: implement using/await using declarations with SuppressedError#5130
Closed
xcb3d wants to merge 1 commit intoboa-dev:mainfrom
Closed
feat: implement using/await using declarations with SuppressedError#5130xcb3d wants to merge 1 commit intoboa-dev:mainfrom
xcb3d wants to merge 1 commit intoboa-dev:mainfrom
Conversation
- Add using/await using declaration parsing with proper ASI, line terminator, and bracket token guards - Add IterableLoopInitializer::Using for for-of loops - Implement SuppressedError built-in constructor per spec - Add disposal opcodes: CreateDisposeCapability, AddDisposableResource, DisposeResources with spec-compliant error chaining - Block using declarations in switch clauses and top-level scripts
Test262 conformance changes
Fixed tests (172):Broken tests (7):Tested main commit: |
Member
|
Duplicate of #5079 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It changes the following:
usingandawait usingdeclaration parsing with proper guards for line terminators (using\nlettriggers ASI), bracket tokens (using[0]is element access), andfor (using of of arr)disambiguationSuppressedErrorbuilt-in constructor (core/engine/src/builtins/error/suppressed.rs) with full prototype chain inheriting fromError, registered as a global bindingCreateDisposeCapability,AddDisposableResource,DisposeResources) implementing the spec'sDisposeResourcesabstract operation with proper error chaining viaSuppressedErrorDisposeResourcesto incorporate pending exception as the initial completion per spec, so body errors and disposal errors are properly combined in theSuppressedErrorchainIterableLoopInitializer::Usingvariant forfor-ofloops with immutable binding semanticsusingdeclarations in switch clause bodies and top-level scripts per spec early errors