Skip to content

test: add coverage for JsTypedArray toReversed, toSorted, toLocaleString #5133

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jedel1043 merged 4 commits into from
Mar 18, 2026
Merged

test: add coverage for JsTypedArray toReversed, toSorted, toLocaleString #5133

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c56ecd0
test: add coverage for JsTypedArray toReversed, toSorted, toLocaleString
Xavrir Mar 18, 2026
419e358
Merge branch 'main' into test/typed-array-missing-coverage
Xavrir Mar 18, 2026
0ff4df2
style: format JsTypedArray imports
Xavrir Mar 18, 2026
375b13c
test: restore JsTypedArray iterator coverage
Xavrir Mar 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
55 changes: 53 additions & 2 deletions core/engine/src/object/builtins/jstypedarray.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1515,8 +1515,7 @@ fn typed_array_values() {
#[test]
fn typed_array_iterator() {
let context = &mut Context::default();
let vec = vec![1u8, 2];
let array = JsUint8Array::from_iter(vec, context).unwrap();
let array = JsUint8Array::from_iter(vec![1u8, 2], context).unwrap();
let values = array.iterator(context).unwrap();
let mut values_vec = Vec::new();
let next_str = crate::js_string!("next");
Expand Down Expand Up @@ -1550,3 +1549,55 @@ fn typed_array_iterator() {
}
assert_eq!(values_vec, vec![JsValue::new(1), JsValue::new(2)]);
}

#[test]
fn typed_array_to_reversed() {
Copy link
Member

@jedel1043 jedel1043 Mar 18, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you deleted the typed_array_iterator test. Can you add that back?

Copy link
Contributor Author

@Xavrir Xavrir Mar 18, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So sorry about that, adding it back asap

Copy link
Contributor Author

@Xavrir Xavrir Mar 18, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in 375b13c. I restored typed_array_iterator and reran cargo test -p boa_engine typed_array_ plus cargo make run-ci locally.

let context = &mut Context::default();
let array = JsUint8Array::from_iter(vec![3u8, 1, 2], context).unwrap();

let reversed = array.to_reversed(context).unwrap();

// New array has reversed order
assert_eq!(reversed.at(0i64, context).unwrap(), JsValue::new(2));
assert_eq!(reversed.at(1i64, context).unwrap(), JsValue::new(1));
assert_eq!(reversed.at(2i64, context).unwrap(), JsValue::new(3));

// Original is unchanged
assert_eq!(array.at(0i64, context).unwrap(), JsValue::new(3));
assert_eq!(array.at(1i64, context).unwrap(), JsValue::new(1));
assert_eq!(array.at(2i64, context).unwrap(), JsValue::new(2));
}

#[test]
fn typed_array_to_sorted() {
let context = &mut Context::default();
let array = JsUint8Array::from_iter(vec![3u8, 1, 2], context).unwrap();

let sorted = array.to_sorted(None, context).unwrap();

// New array is sorted
assert_eq!(sorted.at(0i64, context).unwrap(), JsValue::new(1));
assert_eq!(sorted.at(1i64, context).unwrap(), JsValue::new(2));
assert_eq!(sorted.at(2i64, context).unwrap(), JsValue::new(3));

// Original is unchanged
assert_eq!(array.at(0i64, context).unwrap(), JsValue::new(3));
assert_eq!(array.at(1i64, context).unwrap(), JsValue::new(1));
assert_eq!(array.at(2i64, context).unwrap(), JsValue::new(2));
}

#[test]
fn typed_array_to_locale_string() {
let context = &mut Context::default();
let array = JsUint8Array::from_iter(vec![1u8, 2, 3], context).unwrap();

let result = array.to_locale_string(None, None, context).unwrap();

let result_str = result
.as_string()
.expect("toLocaleString should return a string");
assert!(
result_str.to_std_string_escaped().contains('1'),
"result should contain element values"
);
}
Loading