Skip to content

Fix trace output#5188

Closed
yush-1018 wants to merge 4 commits intoboa-dev:mainfrom
yush-1018:fix-trace-output
Closed

Fix trace output#5188
yush-1018 wants to merge 4 commits intoboa-dev:mainfrom
yush-1018:fix-trace-output

Conversation

@yush-1018
Copy link
Contributor

This PR addresses the trace output formatting overflow in the CLI.

It implements truncation for both the unbounded stack representation strings and the instruction operand strings to ensure they fit neatly within the terminal columns without wrapping or breaking the table alignment.

The unshift fast path introduced in boa-dev#5076 incorrectly bypassed the prototype chain when setting new elements, leading to unobserved setters. This removes the fast path to ensure spec compliance and adds a regression test.
@yush-1018 yush-1018 requested a review from a team as a code owner March 20, 2026 22:02
@github-actions github-actions bot added C-Tests Issues and PRs related to the tests. C-Builtins PRs and Issues related to builtins/intrinsics C-VM Issues and PRs related to the Boa Virtual Machine. Waiting On Review Waiting on reviews from the maintainers labels Mar 20, 2026
@github-actions github-actions bot added this to the v1.0.0 milestone Mar 20, 2026
@github-actions
Copy link

Test262 conformance changes

Test result main count PR count difference
Total 52,963 52,963 0
Passed 50,126 50,126 0
Ignored 2,025 2,025 0
Failed 812 812 0
Panics 0 0 0
Conformance 94.64% 94.64% 0.00%

Tested main commit: b8c684580787968c613045c2588834b4442af518
Tested PR commit: b78c60b99f719b275bb7ffb421414a78522969af
Compare commits: b8c6845...b78c60b

@jedel1043
Copy link
Member

Duplicate of #5104

@jedel1043 jedel1043 marked this as a duplicate of #5104 Mar 20, 2026
@jedel1043 jedel1043 closed this Mar 20, 2026
@github-actions github-actions bot removed the Waiting On Review Waiting on reviews from the maintainers label Mar 20, 2026
@codecov
Copy link

codecov bot commented Mar 20, 2026

Codecov Report

❌ Patch coverage is 0% with 15 lines in your changes missing coverage. Please review.
✅ Project coverage is 59.72%. Comparing base (6ddc2b4) to head (b78c60b).
⚠️ Report is 905 commits behind head on main.

Files with missing lines Patch % Lines
core/engine/src/vm/mod.rs 0.00% 15 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #5188       +/-   ##
===========================================
+ Coverage   47.24%   59.72%   +12.48%     
===========================================
  Files         476      582      +106     
  Lines       46892    63424    +16532     
===========================================
+ Hits        22154    37882    +15728     
- Misses      24738    25542      +804     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@yush-1018 yush-1018 deleted the fix-trace-output branch March 21, 2026 07:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

C-Builtins PRs and Issues related to builtins/intrinsics C-Tests Issues and PRs related to the tests. C-VM Issues and PRs related to the Boa Virtual Machine.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants