Name mangling #2
Conversation
|
I approve. |
|
Maybe without the double underscores, like `@noMangle` or `@no_mangle`
What happened to this
***@***.***` or ***@***.***_mangle`
Remind me not to use email replies anymore
|
lol sorry just a C-ism i'm used to |
|
|
||
| ## Basic example | ||
|
|
||
| A method of the class `foo` with the signature `method(data: int) -> string` in the module `bar.baz` would be mangled to `boad2m3barm3bazc3fooi6methodp1t3i32r5string` |
There was a problem hiding this comment.
Why not something like boa__bar_baz__foo_method__int__string?
There was a problem hiding this comment.
Hmm, I was mostly basing it off rust's mangling, which uses RLE (see prior art), but this could work too. It may be a bit messy to unmangle them, however
There was a problem hiding this comment.
leader__module__class_functionName__paramType_paramType_...__returnType
That's more what I meant
|
|
||
| ## Drawbacks | ||
|
|
||
| - Generating a mangled name can be slightly costly, and can lead to confusing binaries. A possibility to disable mangling for certain symbols should be considered in the future |
There was a problem hiding this comment.
that can be fixed by using things like underscores to act as a sort of whitespace
There was a problem hiding this comment.
Actually, if we choose to go that route, we could use whitespace as whitespace, but it may be a terrible idea
There was a problem hiding this comment.
I more meant that underscores can be a good replacement for actual spaces where spaces aren't allowed in names.
There was a problem hiding this comment.
Yeah, I was referring to the fact that symbols in the binary can have any name we want them to
There was a problem hiding this comment.
underscores def make it nicer, i agree with lyxal here
There was a problem hiding this comment.
Can you try to find some prior art that uses underscores? All I could find uses RLE.
There was a problem hiding this comment.
One other thing of note, humans likely wouldn't look at mangled names directly, they'd see it through something like https://github.com/luser/rustfilt
This RFC describes how name mangling will work in Boa.