Merge pull request #334 from bob-collective/feat/quote-refill-fee

feat: add refill to quote fee
bob-collective · Sep 3, 2024 · 5de1c6a · 5de1c6a
2 parents 554db93 + ff94f5a
commit 5de1c6a
Show file tree

Hide file tree

Showing 4 changed files with 23 additions and 5 deletions.
diff --git a/sdk/package-lock.json b/sdk/package-lock.json
diff --git a/sdk/package.json b/sdk/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@gobob/bob-sdk",
-  "version": "2.2.2",
+  "version": "2.2.3",
   "main": "dist/index.js",
   "types": "dist/index.d.ts",
   "scripts": {

diff --git a/sdk/src/gateway/client.ts b/sdk/src/gateway/client.ts
@@ -129,7 +129,11 @@ export class GatewayApiClient {
             },
         });
 
-        return await response.json();
+        const quote: GatewayQuote = await response.json();
+        return {
+            ...quote,
+            fee: Math.max(0, quote.fee - (params.gasRefill || 0)),
+        };
     }
 
     // TODO: add error handling

diff --git a/sdk/test/gateway.test.ts b/sdk/test/gateway.test.ts
@@ -34,7 +34,7 @@ describe("Gateway Tests", () => {
 
         nock(`${MAINNET_GATEWAY_BASE_URL}`)
             .get(`/quote/${SYMBOL_LOOKUP[ChainId.BOB]["tbtc"].address}?satoshis=1000`)
-            .times(4)
+            .times(6)
             .reply(200, mockQuote);
 
         assert.deepEqual(await gatewaySDK.getQuote({
@@ -61,6 +61,20 @@ describe("Gateway Tests", () => {
             toUserAddress: ZeroAddress,
             amount: 1000,
         }), mockQuote);
+        assert.deepEqual(await gatewaySDK.getQuote({
+            toChain: "BOB",
+            toToken: "tBTC",
+            toUserAddress: ZeroAddress,
+            amount: 1000,
+            gasRefill: 5,
+        }), { ...mockQuote, fee: 5 });
+        assert.deepEqual(await gatewaySDK.getQuote({
+            toChain: "BOB",
+            toToken: "tBTC",
+            toUserAddress: ZeroAddress,
+            amount: 1000,
+            gasRefill: 1000,
+        }), { ...mockQuote, fee: 0 });
 
         // get the total available without amount
         nock(`${MAINNET_GATEWAY_BASE_URL}`)